Bug 2042301

Summary: python-diff-cover FTBFS with Pygments 2.11.2
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-diff-coverAssignee: Aurelien Bompard <aurelien>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: aurelien, infra-sig
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-diff-cover-6.4.4-3.fc37 python-diff-cover-6.4.4-3.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-02-21 22:03:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2036218    

Description Karolina Surma 2022-01-19 08:21:02 UTC
Description of problem:

python-pygments 2.11.2 is heading to Rawhide.
python-diff-cover fails to build on top of this package.

Version-Release number of selected component (if applicable):
6.4.4-1.fc36


Steps to Reproduce:
For local testing:

$ mock -r fedora-rawhide-x86_64 --addrepo=https://download.copr.fedorainfracloud.org/results/ksurma/pygments-2.11.2/fedora-rawhide-x86_64/ --no-clean your.src.rpm
$ mock -r fedora-rawhide-x86_64 --addrepo=https://download.copr.fedorainfracloud.org/results/ksurma/pygments-2.11.2/fedora-rawhide-x86_64/ shell

Actual results:

    def test_style_defs():
        style_str = Snippet.style_defs()
        expected_styles = load_fixture("snippet.css").strip()
    
        # Check that a sample of the styles are present
        # (use only a sample to make the test more robust
        # against Pygments changes).
        for expect_line in expected_styles.split("\n"):
>           assert expect_line in style_str
E           AssertionError: assert '.c { color: #408080; font-style: italic } /* Comment */' in 'pre { line-height: 125%; }\ntd.linenos .normal { color: inherit; background-color: transparent; padding-left: 5px; pa...nstance */\n.vm { color: #19177C } /* Name.Variable.Magic */\n.il { color: #666666 } /* Literal.Number.Integer.Long */'
tests/test_snippets.py:154: AssertionError
=========================== short test summary info ============================
FAILED tests/test_snippets.py::test_style_defs - AssertionError: assert '.c {...
================= 1 failed, 248 passed, 30 deselected in 2.28s =================
error: Bad exit status from /var/tmp/rpm-tmp.EQXhVD (%check)
    Bad exit status from /var/tmp/rpm-tmp.EQXhVD (%check)

Comment 1 Karolina Surma 2022-02-07 12:42:22 UTC
PR containing backported fix for the failing test: https://src.fedoraproject.org/rpms/python-diff-cover/pull-request/5

Comment 2 Ben Cotton 2022-02-08 20:09:47 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 3 Fedora Update System 2022-02-21 22:01:55 UTC
FEDORA-2022-2ad1ad0643 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2ad1ad0643

Comment 4 Fedora Update System 2022-02-21 22:01:56 UTC
FEDORA-2022-3fa69b36fe has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3fa69b36fe

Comment 5 Fedora Update System 2022-02-21 22:03:41 UTC
FEDORA-2022-2ad1ad0643 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2022-02-21 22:03:45 UTC
FEDORA-2022-3fa69b36fe has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.