Bug 2042422

Summary: [ruamel-yaml] ReaderError: unacceptable character on s390x architecture
Product: [Fedora] Fedora Reporter: Mark E. Fuller <mark.e.fuller>
Component: python-ruamel-yaml-clibAssignee: Chandan Kumar <chkumar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 35CC: apevec, chkumar, code, dan, fweimer, jcajka, jcapitao, jmontleo, openstack-sig, smilner
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-26 18:02:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765, 2044056    
Attachments:
Description Flags
fix-typecasts-s390x.patch none

Description Mark E. Fuller 2022-01-19 13:54:52 UTC
Description of problem:

When building and testing Cantera on s390x architecture, a series of tests fail with ruamel.yaml.reader.ReaderError: unacceptable character (e.g. https://download.copr.fedorainfracloud.org/results/fuller/cantera-test/fedora-rawhide-s390x/03195208-cantera/builder-live.log.gz)

These errors do not occur when testing and building the same software on other architectures (e.g. https://copr.fedorainfracloud.org/coprs/fuller/cantera-test/build/3197399/)

The reported unacceptable characters are not present in our input (https://github.com/Cantera/cantera/issues/1174#issuecomment-1015791019)


Version-Release number of selected component (if applicable):

Fedora 34, 35 builds


Proposed solution/workaround:

This issue has been reported upstream (https://sourceforge.net/p/ruamel-yaml/tickets/417/).
The developer suggests patching to increase the buffer size (https://github.com/Cantera/cantera/issues/1174#issuecomment-1016472121)

Comment 1 Alan Pevec (Fedora) 2022-01-25 00:15:35 UTC
> The developer suggests patching to increase the buffer size

Do you have a suggestion for the size or could you sent a PR at https://src.fedoraproject.org/rpms/python-ruamel-yaml/pull-requests ?

Comment 2 Mark E. Fuller 2022-01-25 13:32:49 UTC
Unfortunately no - I don't have any technical insight and the developer's comment on the issue on GH for cantera simply suggested a larger value than current.

Comment 3 Jakub Čajka 2022-05-12 11:39:59 UTC
There is bunch of issues in the C(ython) code related to the implicit type casts few leading to the type demotions, information loss. AFAIK all of those are reported by the C compiler warnings. 
I have fix for the bit that causes issues on the s390x and break in fmf/tmt for me. I'm about to open MR/PR for the packaged with fix and update to the latest upstream versions, for both the clib and python bits of ruamel-yaml.
Here is copr repo with the fixed and updated packages https://copr.fedorainfracloud.org/coprs/jcajka/tmt/.

Comment 5 Joel Capitao 2022-05-25 14:16:14 UTC
FTR, the Jakub's MR/PR have been merged, the packages built, and currently provided in rawhide.


https://koji.fedoraproject.org/koji/taskinfo?taskID=87480513
https://koji.fedoraproject.org/koji/buildinfo?buildID=1965518

Comment 6 Mark E. Fuller 2022-05-26 18:02:12 UTC
I can confirm that this issue is no longer present when building in rawhide or F36, but is still there in F35 (as expected) - closing and thank you

Comment 7 Mark E. Fuller 2022-05-26 18:06:01 UTC
EDIT: Still present in F36- as expected, fixed in rawhide

Comment 8 Florian Weimer 2024-02-01 08:49:53 UTC
Created attachment 2014343 [details]
fix-typecasts-s390x.patch

I had to tweak the patch some more to make the type errors go away.

Upstream reference: https://sourceforge.net/p/ruamel-yaml-clib/tickets/22/