Bug 2042601

Summary:	Upgrade: upgrade started when blockingCR failed silently
Product:	OpenShift Container Platform	Reporter:	yliu1
Component:	Telco Edge	Assignee:	Irina Mihai <imihai>
Telco Edge sub component:	RAN	QA Contact:	yliu1
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	unspecified	CC:	imihai
Version:	4.10
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-26 16:43:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description yliu1 2022-01-19 19:30:31 UTC

Description of problem:
If an UOCR has a blockingCR specified, and that blockingCR failed silently (e.g., has typo in list of clusters), the UOCR will start even though blockingCR never completed. 

Version-Release number of selected component (if applicable):
4.10

How reproducible:
100%

Steps to Reproduce:
1. Create and enable a UOCR with blockingCR
2. Create and enable the blockingCR with a typo in cluster name

Actual results:
2. upgrade started even though blockingCR never completed/started


Expected results:
2. upgrade should not start until blockingCR completed properly

Additional info:

Comment 1 Irina Mihai 2022-02-11 20:19:06 UTC

Fixed in https://github.com/openshift-kni/cluster-group-upgrades-operator/pull/73

Fixes included: Check conditions of CGU and consider CR as not completed if its conditions are nil.

Comment 2 yliu1 2022-02-12 01:16:01 UTC

Verified with latest TALO image.

Upgrade does not start if blockingCR fails silently.

  conditions:
  - lastTransitionTime: "2022-02-12T01:13:59Z"
    message: 'The ClusterGroupUpgrade CR is blocked by other CRs that have not yet
      completed: [upgrade-canariesnotinclusters]'
    reason: UpgradeCannotStart
    status: "False"
    type: Ready
  copiedPolicies: