Bug 2042798

Summary: [RHEL8.6][sfc] General sfc driver update
Product: Red Hat Enterprise Linux 8 Reporter: Íñigo Huguet <ihuguet>
Component: kernelAssignee: Íñigo Huguet <ihuguet>
kernel sub component: NIC Drivers QA Contact: Tianhao <tizhao>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: mcascell, network-qe, tizhao
Version: 8.5Keywords: Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kernel-4.18.0-370.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2042801 (view as bug list) Environment:
Last Closed: 2022-05-10 15:11:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2153066    

Description Íñigo Huguet 2022-01-20 07:17:11 UTC
Update sfc driver including latest upstream patches.

There are not many patches to be included, but some of them are fixes and improvements that allow to support XDP in more scenarios, fixing some related errors as well.

Comment 3 Íñigo Huguet 2022-02-09 07:41:07 UTC
Hi Tianhao, getting reviews for the sfc merge requests is delaying longer than expected. I would wait a few more days and if not I will have to shift the DTM.

Alternatively, since I honestly don't expect any push back from reviewers, you could begin testing, if you wish and have the time.

Thanks.

Comment 4 Íñigo Huguet 2022-02-16 11:21:17 UTC
Hi @tizhao, any chances on getting this verified soon? We'll have to start requesting exceptions if this gets delayed, so better to go forward with it (if you have the time, of course). Same for BZ 1995444 and BZ 2042801.

Comment 5 Tianhao 2022-02-20 15:27:30 UTC
The nic driver functional tests(tier1) are finished on kernel-4.18.0-361.el8.mr2055_220126_1534 with sfc driver.

Test items include:
layered-protocol: partly pass (sctp not tested)
sanity_check(ip/mac/broadcast/multicast/almulti/mtu/promisc/selftest): pass
Card recognize: pass
basic traffic(ping and netperf): pass
statistics in /proc/net/dev: pass
ring buffer setting: pass
driver load and unload: pass
coalesce setting: pass
pause: pass
offload: partly pass, not support geneve offload
vlan_geneve: failed
vlan_vxlan: pass
multiqueue: pass
link_check: pass
hashkey: pass
ethtool/sanity,Regression: pass
vlan/tier1: mostly pass
bridge/setup_bridge,sanity_check,stp_test: pass

related jobs:
https://beaker.engineering.redhat.com/jobs/6277274
https://beaker.engineering.redhat.com/jobs/6287248
https://beaker.engineering.redhat.com/jobs/6231851
https://beaker.engineering.redhat.com/jobs/6230964
https://beaker.engineering.redhat.com/jobs/6230516

known issue:
WARNING: CPU: 47 PID: 45392 at drivers/net/ethernet/sfc/ef10.c:2394 efx_ef10_tx_init+0x247/0x2e0
did not find the corresponding bug. may submit the bug.

Based on the tier1 functional test results, set TESTED.

Comment 6 Íñigo Huguet 2022-02-21 07:11:53 UTC
Are those the correct jobs? They seem to be related to r8169, not sfc.

Comment 7 Tianhao 2022-02-22 02:34:08 UTC
(In reply to Íñigo Huguet from comment #6)
> Are those the correct jobs? They seem to be related to r8169, not sfc.

sorry, the jobs are incorrect. Thanks for pointing it out.

The jobs are:
https://beaker.engineering.redhat.com/jobs/6287309
https://beaker.engineering.redhat.com/jobs/6287699
https://beaker.engineering.redhat.com/jobs/6287448
https://beaker.engineering.redhat.com/jobs/6287123
https://beaker.engineering.redhat.com/jobs/6287127

Comment 8 Íñigo Huguet 2022-02-22 08:51:58 UTC
(In reply to Tianhao from comment #5)
> known issue:
> WARNING: CPU: 47 PID: 45392 at drivers/net/ethernet/sfc/ef10.c:2394
> efx_ef10_tx_init+0x247/0x2e0
> did not find the corresponding bug. may submit the bug.

I see that the problem is when modprobing with param efx_separate_tx_channels=y.

This is a known bug that won't be fixed, see BZ 1931024

Comment 12 Tianhao 2022-03-01 06:49:17 UTC
Done code check.

The tier2 nic functional tests pass on kernel-4.18.0-370.el8 on sfc driver.

Test includes:
scaling: pass
setup topo via NetworkManager and reboot: pass

related job:
https://beaker.engineering.redhat.com/jobs/6335852

There is no regressions found in testing, based on the tier1 test results on dt kernel and tier2 test results on candidate kernel, set VERFIED.

Comment 14 errata-xmlrpc 2022-05-10 15:11:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1988

Comment 15 Mauro Matteo Cascella 2023-06-12 11:00:04 UTC
*** Bug 2214247 has been marked as a duplicate of this bug. ***