Bug 2043035

Summary:	Wrong error code provided when request contains invalid argument
Product:	OpenShift Container Platform	Reporter:	Vojtech Juranek <vjuranek>
Component:	Storage	Assignee:	Vojtech Juranek <vjuranek>
Storage sub component:	oVirt CSI Driver	QA Contact:	michal <mgold>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	jpasztor, mburman
Version:	4.10
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-10 10:43:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vojtech Juranek 2022-01-20 14:14:07 UTC

Description of problem:

When user requests PVC with unsupported access mode (see BZ #1882983), exception without any error code is thrown. However, CSI specification requires to return gRPC error code INVALID_ARGUMENT:

    Invalid or unsupported field in the request 	3 INVALID_ARGUMENT 	Indicates that the one or more fields in this field is either not allowed by the Plugin or has an invalid value. More human-readable information MAY be provided in the gRPC status.message field.


Steps to Reproduce:
See reproducer in BZ #1882983 and check error returned by the plugin in the controller log.

Comment 3 michal 2022-02-15 12:22:02 UTC

ocp: 4.11.0-0.nightly-2022-02-10-031822
1) create pvc with Access mode - ReadWriteMany
2) look on log of pod controller - 'oc logs -c csi-provisioner  pod/ovirt-csi-driver-controller-767f5bf5c8-cmplq'
excpected error appear:
 
I0215 10:06:30.390817       1 event.go:285] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"openshift-cluster-csi-drivers", Name:"pv-claim", UID:"fcd8f59d-286b-4f93-9c6e-7e596f52c653", APIVersion:"v1", ResourceVersion:"2653170", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provision volume with StorageClass "ovirt-csi-sc": rpc error: code = InvalidArgument desc = unsupported access mode MULTI_NODE_MULTI_WRITER, currently only RWO is supported

and pvc is stuck on pending state  (this is the correct behavier)

Comment 6 errata-xmlrpc 2022-08-10 10:43:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069