Bug 204343
Summary: | Review Request: qcomicbook - a comic book viewing program | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Scott Baker <scott> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mtasaka, panemade |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.3.2-6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-20 20:45:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Scott Baker
2006-08-28 16:33:19 UTC
This package can't require unrar, since it is not allowed into FE. Good catch... Updated and reposted. SRPM: http://www.perturb.org/tmp/qcomicbook-0.3.2-3.src.rpm Spec URL: http://www.perturb.org/tmp/qcomicbook.spec Couple of quick items (note this is not an official review): 1. Desktop file is not handled correctly. Refer to http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 2. In the build section you should use 'make %{?_smp_mflags}' instead of '%{__make}' 3. The Requires on qt & imlib2 are unnecessary since the sonames on the devel packages will pull these in. 4. You should use 'rm -rf $RPM_BUILD_ROOT' instead of '[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf "$RPM_BUILD_ROOT"' in your spec. Updated the package with the comments in #3. rpmlint is clean on the SRPM and the binary RPM. SRPM: http://www.perturb.org/tmp/qcomicbook-0.3.2-4.src.rpm Spec URL: http://www.perturb.org/tmp/qcomicbook.spec Don't set BuildArch. The build system builds on i386 not i686, so it won't build with mock. Not only that, but this breaks other architectures like x86_64 and ppc. If you must force it to build on certain arches only use ExclusiveArch. I don't think this will be necessary. packaging looks ok. + Mockbuild is successfull for i386 FC6 + rpmlint on binary rpm is silent + dist tag is present + Buildroot is correct + source URL is correct + BR is correct + License used is GPL + License file COPYING is included + Desktop file is handled correctly + MD5 sum on tarball is matching upstream tarball ab191878d0694c77c4e5dd1d22f3d14c qcomicbook-0.3.2.tar.gz + No duplicate files I removed the buildarch and created a new release. SRPM: http://www.perturb.org/tmp/qcomicbook-0.3.2-5.src.rpm Spec URL: http://www.perturb.org/tmp/qcomicbook.spec + Built and run on fc5 x86_64. Also built on fc6 x86_64. + Sucessfully extracted .tar.gz, .tar.bz, and .zip files. + I agree with comment 6 - It does not appear in my Gnome menus for some reason. Well, this pachage (-0.3.2-5) fails to be rebuilt in mock on 2.6.17-1.2174_FC5smp with leaving the logs: config.status: creating Makefile config.status: creating src/Makefile config.status: creating icons/Makefile config.status: creating help/Makefile config.status: creating help/en/Makefile config.status: creating src/config.h config.status: executing depfiles commands + -j2 /var/tmp/rpm-tmp.30019: line 50: -j2: command not found error: Bad exit status from /var/tmp/rpm-tmp.30019 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.30019 (%build) Error building package from qcomicbook-0.3.2-5.fc5.src.rpm, See build log ending DEBUG: Executing /usr/sbin/mock-helper umount /var/lib/mock/fedora-5-i386-core/root/proc DEBUG: Executing /usr/sbin/mock-helper umount /var/lib/mock/fedora-5-i386-core/root/dev/pts done ... by a apparent typo in spec file ( the line %{?_smp_mflags} ) (In reply to comment #9) > Well, this pachage (-0.3.2-5) fails to be rebuilt in mock > ... by a apparent typo in spec file ( the line %{?_smp_mflags} ) Correct, 'make %{?_smp_mflags}' should be used instead of '%{?_smp_mflags}' Oh good catch. Updated spec and package: SRPM: http://www.perturb.org/tmp/qcomicbook-0.3.2-6.src.rpm Spec: http://www.perturb.org/tmp/qcomicbook.spec + Comment 8 still applies. + file permissions good + proper macros + follows naming guidelines + rpmlint clean For readability consider removing the unused commented out lines. APPROVED Hello, John. Did you accept to sponsor Scott? This is in fact NEEDSPONSOR issue. See bug 199780. Yes I am sponsoring. Apply for cvsextras. I still highly recommend removing the commented out lines for readibility, however. Without syntax highlighting it is difficult to see what lines are evaluated and which are not. I applied for CVS extras. What's next? (In reply to comment #15) > I applied for CVS extras. What's next? Please follow : http://fedoraproject.org/wiki/Extras/Contributors I applied for cvsextras (or so I thought). I tried to do it again today and I get an error: 'Add' action denied. You may need to become a member of the cla_done group first. I'm "in progress" in the cla_done group. I don't even know what that is. Well, I cannot see qcomicbook on buildsys or mirror server yet. What is happening? |