Bug 2043531

Summary: Guest can not start with SLIC acpi table
Product: Red Hat Enterprise Linux 9 Reporter: yalzhang <yalzhang>
Component: qemu-kvmAssignee: Julia Suvorova <jusual>
qemu-kvm sub component: General QA Contact: jingzhao <jinzhao>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: ailan, coli, imammedo, jinzhao, jusual, juzhang, lmiksik, meili, mrezanin, virt-maint, xuwei, yiwei, ymankad
Version: 9.0Keywords: Regression, Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-kvm-6.2.0-11.el9_0.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2062809 (view as bug list) Environment:
Last Closed: 2022-05-17 12:25:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2062809    

Description yalzhang@redhat.com 2022-01-21 13:29:02 UTC 
Description of problem:
Guest can not start with SLIC acpi table

Version-Release number of selected component (if applicable):
qemu-kvm-6.2.0-4.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Try to start vm with below xml:
(the slic.dat file get from bug 1248758#c42)
<os>
   ...
    <acpi>
      <table type='slic'>/tmp/slic.dat</table>
    </acpi>
    ...
  </os>

2. Before qemu 6.2, the vm can start successfully. But now, it fails as:
# virsh start rhel86
error: Failed to start domain 'rhel86'
error: internal error: qemu unexpectedly closed the monitor: **
ERROR:../hw/acpi/aml-build.c:61:build_append_padded_str: assertion failed: (len <= maxlen)
Bail out! ERROR:../hw/acpi/aml-build.c:61:build_append_padded_str: assertion failed: (len <= maxlen)

Actual results:
Guest can not start with SLIC acpi table

Expected results:
Guest can start successfully

Additional info:
Comment 3 Igor Mammedov 2022-02-09 14:49:01 UTC 
Upstream fixes to backport:

c8adb4d222 tests: acpi: SLIC: update expected blobs
11edfabee4 tests: acpi: add SLIC table test
e71f6ab9d9 tests: acpi: whitelist expected blobs before changing them
8cdb99af45 acpi: fix QEMU crash when started with SLIC table

and

408ca92634 tests: acpi: test short OEM_ID/OEM_TABLE_ID values in test_oem_fields()
5adc3aba87 tests: acpi: update expected blobs
748c030f36 acpi: fix OEM ID/OEM Table ID padding
d1e4a46541 tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobs
a849522f72 tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() test
Comment 11 Igor Mammedov 2022-03-18 13:06:24 UTC 
jingzhao,

can you please verify with following RHEL9.0 brew build:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=4392917
Comment 18 Yanan Fu 2022-03-23 06:29:39 UTC 
QE bot(pre verify): Set 'Verified:Tested,SanityOnly' as gating/tier1 test pass.
Comment 24 errata-xmlrpc 2022-05-17 12:25:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: qemu-kvm), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2307