Bug 2044873

Summary: annocheck FAIL: pie test (ignition)
Product: Red Hat Enterprise Linux 9 Reporter: Rui Ormonde <rlemosor>
Component: ignitionAssignee: Sohan Kunkerkar <skunkerk>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0CC: hhei, travier
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-04 10:23:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2003965    
Bug Blocks: 2044387    

Description Rui Ormonde 2022-01-25 10:34:51 UTC
Failed test: pie test

Test results:
\n Hardened: ignition: FAIL: pie test because not built with '-Wl'-pie' (gcc/clang) or '-buildmode pie' (go)

Applicable RPMs:
ignition-2.9.0-7.el9.ppc64le.rpm; ignition-2.9.0-7.el9.s390x.rpm; ignition-2.9.0-7.el9.x86_64.rpm

Recommendation: Please fix the build system for the package or else add a skip of tests to the rpminspect.yaml file. For more details please see https://sourceware.org/annobin/annobin.html/Test-pie.html and https://sourceware.org/annobin/annobin.html/Waiving-Hardened-Results.html#Waiving-Hardened-Results.

Why this bug was filed: All packages in RHEL 9 built with gcc (g++, etc.) are required to use a common set of flags provided by the distribution. These flags turn on important security and performance features so it is critical that any package that lacks these flags be repaired. A scanning tool named annocheck, part of the annobin package, was used to scan RHEL 9 packages. This BZ was created because binary packages of this component with the mentioned NVRs were not built with the requisite flags for one or more RHEL 9 architectures.

How to reproduce the failure: You could try running annocheck locally against your builds: https://developers.redhat.com/blog/2019/02/04/annocheck-examining-the-contents-of-binary-files.

Annocheck resources:
* annobin documentation: https://sourceware.org/annobin/annobin.html/index.html
* annocheck on the customer portal: https://access.redhat.com/documentation/en-us/red_hat_developer_toolset/9/html/user_guide/chap-annobin

Contacts:
* Instant messaging: #tools on IRC
* Email: use tools for generic questions. Otherwise, use go-tools and llvm-clang-list for Go and Clang/LLVM specific questions.
* annobin-annocheck maintainer: Nick Clifton (nickc)

Comment 2 Timothée Ravier 2022-01-25 15:18:40 UTC
Should be fixed with https://bugzilla.redhat.com/show_bug.cgi?id=2003965

Comment 3 HuijingHei 2022-04-11 14:39:45 UTC
According to https://bugzilla.redhat.com/show_bug.cgi?id=2003965#c15, install on a RHEL 9 VM with ignition-2.13.0-1.el9.x86_64 and works well. Change status verified.

# rpm -q ignition
ignition-2.13.0-1.el9.x86_64
# /usr/lib/dracut/modules.d/30ignition/ignition --version
Ignition 2.13.0

Comment 5 Timothée Ravier 2023-07-04 10:23:06 UTC
We forgot to attach this to an errata. Closing.