Bug 2045342

Summary: elfutils: FTBFS in Fedora rawhide/f36
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: elfutilsAssignee: Mark Wielaard <mjw>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: aoliva, fche, jakub, mcermak, me, mjw
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: elfutils-0.186-3.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-05 00:15:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1992484, 2045102    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2022-01-25 16:28:28 UTC
elfutils failed to build from source in Fedora rawhide/f36

https://koji.fedoraproject.org/koji/taskinfo?taskID=81770859


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
Please fix elfutils at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
elfutils will be orphaned. Before branching of Fedora 37,
elfutils will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2022-01-25 16:28:33 UTC
Created attachment 1854046 [details]
build.log

file build.log too big, will only attach last 32768 bytes

Comment 2 Fedora Release Engineering 2022-01-25 16:28:35 UTC
Created attachment 1854047 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2022-01-25 16:28:37 UTC
Created attachment 1854048 [details]
state.log

Comment 4 Frank Ch. Eigler 2022-01-25 17:02:27 UTC
gcc -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"/usr/share/locale"' -I. -I..  -I. -I. -I../lib -I.. -I. -I./../libelf -I./../libebl -I./../libdw -I./../libdwelf -I./../debuginfod  -std=gnu99 -Wall -Wshadow -Wformat=2 -Wold-style-definition -Wstrict-prototypes -Wtrampolines -Wlogical-op -Wduplicated-cond -Wnull-dereference -Wimplicit-fallthrough=5 -Werror -Wunused -Wextra -Wstack-usage=262144   -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe  -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wformat -c -o zstd.o zstd.c
In file included from zstd.c:4:
gzip.c: In function '__libdw_unzstd':
gzip.c:400:16: error: pointer may be used after 'realloc' [-Werror=use-after-free]
  400 |   *state.whole = state.buffer;
      |   ~~~~~~~~~~~~~^~~~~~~~~~~~~~
In function 'smaller_buffer',
    inlined from '__libdw_unzstd' at gzip.c:299:3:
gzip.c:110:7: note: call to 'realloc' here
  110 |       realloc (state->buffer, end) ?: end == 0 ? NULL : state->buffer;
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:711: zstd.o] Error 1

Comment 5 Mark Wielaard 2022-01-25 18:08:13 UTC
That realloc issue is an upstream GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104069

Comment 6 Mark Wielaard 2022-01-25 18:10:21 UTC
(In reply to Mark Wielaard from comment #5)
> That realloc issue is an upstream GCC bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104069

Fix should be in gcc-12.0.1-0.3.fc36 currently building:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1903850

Comment 7 Mark Wielaard 2022-01-26 23:21:24 UTC
(In reply to Mark Wielaard from comment #6)
> (In reply to Mark Wielaard from comment #5)
> > That realloc issue is an upstream GCC bug:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104069
> 
> Fix should be in gcc-12.0.1-0.3.fc36 currently building:
> https://koji.fedoraproject.org/koji/buildinfo?buildID=1903850

That gcc version is now in rawhide, but building elfutils still fails:
https://kojipkgs.fedoraproject.org//work/tasks/1096/81971096/build.log

Making all in lib
gcc -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"/usr/share/locale"' -I. -I..  -I. -I. -I../lib -I.. -I./../libelf  -std=gnu99 -Wall -Wshadow -Wformat=2 -Wold-style-definition -Wstrict-prototypes      -Werror -Wunused -Wextra     -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe  -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wformat -c -o error.o error.c
error.c: error: -D_FORTIFY_SOURCE not defined [-Werror]
cc1: all warnings being treated as errors
make[2]: *** [Makefile:489: error.o] Error 1

I am not sure why that is.

Comment 8 Jakub Jelinek 2022-01-27 10:11:32 UTC
Apparently annobin.  Florian has rebuilt it, so just retry.

Comment 9 Mark Wielaard 2022-01-27 11:09:58 UTC
(In reply to Jakub Jelinek from comment #8)
> Apparently annobin.  Florian has rebuilt it, so just retry.

Thanks. That fixed the -D_FORTIFY_SOURCE issues.
https://koji.fedoraproject.org/koji/taskinfo?taskID=82002135
Next up the FDO package ElF notes.
Some self-tests fail because elflint doesn't recognize those.
But there is an upstream patch for that. Just needs backporting.

Comment 10 Ben Cotton 2022-02-08 20:28:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 11 Fedora Update System 2022-03-25 22:39:41 UTC
FEDORA-2022-69e21edb9f has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-69e21edb9f

Comment 12 Fedora Update System 2022-03-27 01:58:22 UTC
FEDORA-2022-69e21edb9f has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-69e21edb9f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-69e21edb9f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-04-05 00:15:39 UTC
FEDORA-2022-69e21edb9f has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.