Bug 2045924

Summary: Review Request: sdrangel - SDR and signal analyzer frontend to various hardware
Product: [Fedora] Fedora Reporter: Jaroslav Škarvada <jskarvad>
Component: Package ReviewAssignee: Petr Menšík <pemensik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, pemensik
Target Milestone: ---Flags: pemensik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-12 00:56:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2045294    
Bug Blocks:    
Attachments:
Description Flags
licensecheck.txt
none
HIDAPI unbundling patch none

Description Jaroslav Škarvada 2022-01-26 00:08:50 UTC 
Spec URL: https://jskarvad.fedorapeople.org/sdrangel/sdrangel.spec
SRPM URL: https://jskarvad.fedorapeople.org/sdrangel/sdrangel-6.18.1-1.fc34.src.rpm
Description: SDR and signal analyzer frontend to various hardware.
Fedora Account System Username: jskarvad
Comment 1 Jaroslav Škarvada 2022-01-26 00:10:52 UTC 
This requires serialdv (bug 2045294).
Comment 2 Petr Menšík 2022-01-29 02:05:44 UTC 
Oh, those has quite juicy dependencies. I failed building multiple times, I have to make more space to build that.
Comment 3 Petr Menšík 2022-01-29 13:57:42 UTC 
fcdhid/hidapi.h seems to be ancient version [1.1] of today's hidapi [1.2], which has own hidapi-devel package ready on Fedora. Either it should declare bundled(hidapi), better it should be modified to work and link with hidapi package if possible. If not possible, it should describe briefly reason for it in spec. Ideally provides should also report bundled version, if upstream is able to provide it.

I think qrtplib subdirectory contains JRTPLIB, which should be declared by Provides: bundled(JRTPLIB) [2].

httpserver contains part of QtWebApp, should Provides: bundled(QtWebApp) as well [3].

Sources provide also rescuesdriq tool written in Go language. Might be built as well, but I admit I lack knowledge to build go project in proper way. That is purely optional.

1.1. https://github.com/signal11/hidapi
1.2. https://github.com/libusb/hidapi
2. https://github.com/j0r1/JRTPLIB/tree/master/src
3. http://stefanfrings.de/qtwebapp/index-en.html
Comment 4 Petr Menšík 2022-01-29 14:09:03 UTC 
Created attachment 1857573 [details]
licensecheck.txt

License check detected quite a lot different licenses uses. Some are just few headers, like Apache 2.0 license. But MIT covers rtp part of quite a lot of files. I think all used licenses have to be noted in License: tag if they are used to build binary outputs.

It should be noted in spec which parts are covered by which license. Current GPLv3 license it not clearly enough, I am confident at least some of other licenses are used to produce binaries. It should be described which files are covered by which license. Details are in licensing guidelines [1].

1. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios
Comment 5 Petr Menšík 2022-01-29 14:33:52 UTC 
I would like SDR term explained in package description. I know it might be Software Defined Radio, but I guess just single line is not enough to describe GUI application with so many plugins. User should not guess what it does from main package description.

I think wiki would be good source for user descriptive text [1]. It seems no simple application, I would expect at least 3 lines describing who and for what can use it. I know it is highly technical application. Put please spend some words on it.

1. https://github.com/f4exb/sdrangel/wiki/Quick-start
Comment 6 Petr Menšík 2022-01-29 14:41:54 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License", "GNU
     General Public License, Version 3", "GNU General Public License v3.0
     or later", "*No copyright* GNU General Public License, Version 3",
     "*No copyright* GNU Lesser General Public License", "GNU Lesser
     General Public License, Version 3", "MIT License", "GNU General Public
     License v2.0 or later", "GNU Lesser General Public License v3.0 or
     later", "BSD (3 clause)", "Apache License 2.0", "GNU General Public
     License Boost Software License 1.0", "Do What The Fuck You Want To
     Public License, Version 2", "*No copyright* GNU General Public License
     v2.0 or later", "the Unlicense MIT License Apache License 2.0". 4713
     files have unknown license. Detailed output of licensecheck in
     /home/reviewer/fedora/rawhide/2045924-sdrangel/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/scalable
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
     Note: hidapi is packaged, other libraries should be marked bundled
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
     Note: unowned directories exist, check above
[x]: Spec file is legible and written in American English.
[!]: Package contains systemd file(s) if in need.
     Note: there seems to be sdrangelsrv server, which might have some systemd unit
     Should it have separate subpackage also?
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 81920 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: sdrangel-6.18.1-1.fc36.x86_64.rpm
          sdrangel-debuginfo-6.18.1-1.fc36.x86_64.rpm
          sdrangel-debugsource-6.18.1-1.fc36.x86_64.rpm
          sdrangel-6.18.1-1.fc36.src.rpm
sdrangel.x86_64: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end
sdrangel.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end
sdrangel.x86_64: W: no-manual-page-for-binary sdrangel
sdrangel.x86_64: W: no-manual-page-for-binary sdrangelbench
sdrangel.x86_64: W: no-manual-page-for-binary sdrangelsrv
sdrangel.src: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end
sdrangel.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end
4 packages and 0 specfiles checked; 0 errors, 7 warnings.




Rpmlint (debuginfo)
-------------------
Checking: sdrangel-debuginfo-6.18.1-1.fc36.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
sdrangel: /usr/lib64/sdrangel/libfcdhid.so
sdrangel: /usr/lib64/sdrangel/libfcdlib.so
sdrangel: /usr/lib64/sdrangel/libhackrfdevice.so
sdrangel: /usr/lib64/sdrangel/libhttpserver.so
sdrangel: /usr/lib64/sdrangel/liblogging.so
sdrangel: /usr/lib64/sdrangel/libmetisdevice.so
sdrangel: /usr/lib64/sdrangel/libplutosdrdevice.so
sdrangel: /usr/lib64/sdrangel/libqrtplib.so
sdrangel: /usr/lib64/sdrangel/libsdrbase.so
sdrangel: /usr/lib64/sdrangel/libsdrbench.so
sdrangel: /usr/lib64/sdrangel/libsdrgui.so
sdrangel: /usr/lib64/sdrangel/libsdrsrv.so
sdrangel: /usr/lib64/sdrangel/libswagger.so
sdrangel: /usr/lib64/sdrangel/libusrpdevice.so
sdrangel: /usr/lib64/sdrangel/plugins/libantennatools.so
sdrangel: /usr/lib64/sdrangel/plugins/libaprs.so
sdrangel: /usr/lib64/sdrangel/plugins/libbeamsteeringcwmod.so
sdrangel: /usr/lib64/sdrangel/plugins/libchanalyzer.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodadsb.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodais.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodam.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodatv.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodbfm.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodchirpchat.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodfreedv.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodnfm.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodpacket.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodpager.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodssb.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodvor.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodvorsc.so
sdrangel: /usr/lib64/sdrangel/plugins/libdemodwfm.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeatureafc.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeatureais.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeaturedemodanalyzer.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeaturegs232controller.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeaturepertester.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeaturerigctlserver.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeaturesimpleptt.so
sdrangel: /usr/lib64/sdrangel/plugins/libfeaturestartracker.so
sdrangel: /usr/lib64/sdrangel/plugins/libfilesink.so
sdrangel: /usr/lib64/sdrangel/plugins/libfilesource.so
sdrangel: /usr/lib64/sdrangel/plugins/libfreqtracker.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputairspy.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputaudio.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputfcdpro.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputfcdproplus.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputfileinput.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputhackrf.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputkiwisdr.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputlocal.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputplutosdr.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputrtlsdr.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputtestsource.so
sdrangel: /usr/lib64/sdrangel/plugins/libinputusrp.so
sdrangel: /usr/lib64/sdrangel/plugins/libinterferometer.so
sdrangel: /usr/lib64/sdrangel/plugins/libjogdialcontroller.so
sdrangel: /usr/lib64/sdrangel/plugins/liblocalsink.so
sdrangel: /usr/lib64/sdrangel/plugins/liblocalsource.so
sdrangel: /usr/lib64/sdrangel/plugins/libmap.so
sdrangel: /usr/lib64/sdrangel/plugins/libmimometismiso.so
sdrangel: /usr/lib64/sdrangel/plugins/libmimoplutosdr.so
sdrangel: /usr/lib64/sdrangel/plugins/libmimotestmi.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodais.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodam.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodatv.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodchirpchat.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodfreedv.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodieee_802_15_4.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodnfm.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodpacket.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodssb.so
sdrangel: /usr/lib64/sdrangel/plugins/libmodwfm.so
sdrangel: /usr/lib64/sdrangel/plugins/libnoisefigure.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputaudio.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputfileoutput.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputhackrf.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputlocal.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputplutosdr.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputtestmosync.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputtestsink.so
sdrangel: /usr/lib64/sdrangel/plugins/liboutputusrp.so
sdrangel: /usr/lib64/sdrangel/plugins/libradioastronomy.so
sdrangel: /usr/lib64/sdrangel/plugins/libradioclock.so
sdrangel: /usr/lib64/sdrangel/plugins/libudpsink.so
sdrangel: /usr/lib64/sdrangel/plugins/libudpsource.so
sdrangel: /usr/lib64/sdrangel/plugins/libvorlocalizer.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libantennatoolssrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libaprssrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libbeamsteeringcwmodsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodadsbsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodaissrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodamsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodbfmsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodchirpchatsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodfreedvsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodnfmsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodpacketsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodpagersrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodssbsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodvorscsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodvorsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libdemodwfmsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeatureafcsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeatureaissrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeaturedemodanalyzersrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeaturegs232controllersrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeaturepertestersrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeaturerigctlserversrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeaturesimplepttsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfeaturestartrackersrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfilesinksrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfilesourcesrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libfreqtrackersrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputairspysrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputaudiosrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputfcdproplussrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputfcdprosrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputfileinputsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputhackrfsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputkiwisdrsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputlocalsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputplutosdrsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputrtlsdrsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputtestsourcesrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libinputusrpsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liblocalsinksrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liblocalsourcesrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmapsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmimometismisosrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmimoplutosdrsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmimotestmisrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodaissrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodamsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodatvsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodchirpchatsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodfreedvsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodieee_802_15_4srv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodnfmsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodpacketsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodssbsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libmodwfmsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libnoisefiguresrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputaudiosrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputfileoutputsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputhackrfsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputlocalsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputplutosdrsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputtestmosyncsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputtestsinksrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/liboutputusrpsrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libradioastronomysrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libradioclocksrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libudpsinksrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libudpsourcesrv.so
sdrangel: /usr/lib64/sdrangel/pluginssrv/libvorlocalizersrv.so

Source checksums
----------------
https://github.com/f4exb/sdrangel/archive/v6.18.1/sdrangel-6.18.1.tar.gz :
  CHECKSUM(SHA256) this package     : 5b258c829e8a3ab769b4bf64299e7de6477c70f3570987212260268b40f7097e
  CHECKSUM(SHA256) upstream package : 5b258c829e8a3ab769b4bf64299e7de6477c70f3570987212260268b40f7097e


Requires
--------
sdrangel (rpmlib, GLIBC filtered):
    glibc
    libOpenGL.so.0()(64bit)
    libQt5Charts.so.5()(64bit)
    libQt5Charts.so.5(Qt_5)(64bit)
    libQt5Charts.so.5(Qt_5.15.2_PRIVATE_API)(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Location.so.5()(64bit)
    libQt5Location.so.5(Qt_5)(64bit)
    libQt5Multimedia.so.5()(64bit)
    libQt5Multimedia.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5OpenGL.so.5()(64bit)
    libQt5OpenGL.so.5(Qt_5)(64bit)
    libQt5Positioning.so.5()(64bit)
    libQt5Positioning.so.5(Qt_5)(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libQt5QuickWidgets.so.5()(64bit)
    libQt5QuickWidgets.so.5(Qt_5)(64bit)
    libQt5SerialPort.so.5()(64bit)
    libQt5SerialPort.so.5(Qt_5)(64bit)
    libQt5TextToSpeech.so.5()(64bit)
    libQt5TextToSpeech.so.5(Qt_5)(64bit)
    libQt5WebSockets.so.5()(64bit)
    libQt5WebSockets.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libairspy.so.0()(64bit)
    libc.so.6()(64bit)
    libcodec2.so.1.0()(64bit)
    libfcdhid.so()(64bit)
    libfcdlib.so()(64bit)
    libfftw3f.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhackrf.so.0()(64bit)
    libhackrfdevice.so()(64bit)
    libhttpserver.so()(64bit)
    libiio.so.0()(64bit)
    liblogging.so()(64bit)
    libm.so.6()(64bit)
    libmetisdevice.so()(64bit)
    libmvec.so.1()(64bit)
    libopencv_core.so.4.5()(64bit)
    libopencv_imgcodecs.so.4.5()(64bit)
    libopencv_imgproc.so.4.5()(64bit)
    libopencv_videoio.so.4.5()(64bit)
    libopus.so.0()(64bit)
    libplutosdrdevice.so()(64bit)
    libqrtplib.so()(64bit)
    librtlsdr.so.0()(64bit)
    libsdrbase.so()(64bit)
    libsdrbench.so()(64bit)
    libsdrgui.so()(64bit)
    libsdrsrv.so()(64bit)
    libserialdv.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libswagger.so()(64bit)
    libuhd.so.4.1.0()(64bit)
    libusb-1.0.so.0()(64bit)
    libusrpdevice.so()(64bit)
    rtld(GNU_HASH)

sdrangel-debuginfo (rpmlib, GLIBC filtered):

sdrangel-debugsource (rpmlib, GLIBC filtered):



Provides
--------
sdrangel:
    application()
    application(sdrangel.desktop)
    libantennatools.so()(64bit)
    libantennatoolssrv.so()(64bit)
    libaprs.so()(64bit)
    libaprssrv.so()(64bit)
    libbeamsteeringcwmod.so()(64bit)
    libbeamsteeringcwmodsrv.so()(64bit)
    libchanalyzer.so()(64bit)
    libdemodadsb.so()(64bit)
    libdemodadsbsrv.so()(64bit)
    libdemodais.so()(64bit)
    libdemodaissrv.so()(64bit)
    libdemodam.so()(64bit)
    libdemodamsrv.so()(64bit)
    libdemodatv.so()(64bit)
    libdemodbfm.so()(64bit)
    libdemodbfmsrv.so()(64bit)
    libdemodchirpchat.so()(64bit)
    libdemodchirpchatsrv.so()(64bit)
    libdemodfreedv.so()(64bit)
    libdemodfreedvsrv.so()(64bit)
    libdemodnfm.so()(64bit)
    libdemodnfmsrv.so()(64bit)
    libdemodpacket.so()(64bit)
    libdemodpacketsrv.so()(64bit)
    libdemodpager.so()(64bit)
    libdemodpagersrv.so()(64bit)
    libdemodssb.so()(64bit)
    libdemodssbsrv.so()(64bit)
    libdemodvor.so()(64bit)
    libdemodvorsc.so()(64bit)
    libdemodvorscsrv.so()(64bit)
    libdemodvorsrv.so()(64bit)
    libdemodwfm.so()(64bit)
    libdemodwfmsrv.so()(64bit)
    libfcdhid.so()(64bit)
    libfcdlib.so()(64bit)
    libfeatureafc.so()(64bit)
    libfeatureafcsrv.so()(64bit)
    libfeatureais.so()(64bit)
    libfeatureaissrv.so()(64bit)
    libfeaturedemodanalyzer.so()(64bit)
    libfeaturedemodanalyzersrv.so()(64bit)
    libfeaturegs232controller.so()(64bit)
    libfeaturegs232controllersrv.so()(64bit)
    libfeaturepertester.so()(64bit)
    libfeaturepertestersrv.so()(64bit)
    libfeaturerigctlserver.so()(64bit)
    libfeaturerigctlserversrv.so()(64bit)
    libfeaturesimpleptt.so()(64bit)
    libfeaturesimplepttsrv.so()(64bit)
    libfeaturestartracker.so()(64bit)
    libfeaturestartrackersrv.so()(64bit)
    libfilesink.so()(64bit)
    libfilesinksrv.so()(64bit)
    libfilesource.so()(64bit)
    libfilesourcesrv.so()(64bit)
    libfreqtracker.so()(64bit)
    libfreqtrackersrv.so()(64bit)
    libhackrfdevice.so()(64bit)
    libhttpserver.so()(64bit)
    libinputairspy.so()(64bit)
    libinputairspysrv.so()(64bit)
    libinputaudio.so()(64bit)
    libinputaudiosrv.so()(64bit)
    libinputfcdpro.so()(64bit)
    libinputfcdproplus.so()(64bit)
    libinputfcdproplussrv.so()(64bit)
    libinputfcdprosrv.so()(64bit)
    libinputfileinput.so()(64bit)
    libinputfileinputsrv.so()(64bit)
    libinputhackrf.so()(64bit)
    libinputhackrfsrv.so()(64bit)
    libinputkiwisdr.so()(64bit)
    libinputkiwisdrsrv.so()(64bit)
    libinputlocal.so()(64bit)
    libinputlocalsrv.so()(64bit)
    libinputplutosdr.so()(64bit)
    libinputplutosdrsrv.so()(64bit)
    libinputrtlsdr.so()(64bit)
    libinputrtlsdrsrv.so()(64bit)
    libinputtestsource.so()(64bit)
    libinputtestsourcesrv.so()(64bit)
    libinputusrp.so()(64bit)
    libinputusrpsrv.so()(64bit)
    libinterferometer.so()(64bit)
    libjogdialcontroller.so()(64bit)
    liblocalsink.so()(64bit)
    liblocalsinksrv.so()(64bit)
    liblocalsource.so()(64bit)
    liblocalsourcesrv.so()(64bit)
    liblogging.so()(64bit)
    libmap.so()(64bit)
    libmapsrv.so()(64bit)
    libmetisdevice.so()(64bit)
    libmimometismiso.so()(64bit)
    libmimometismisosrv.so()(64bit)
    libmimoplutosdr.so()(64bit)
    libmimoplutosdrsrv.so()(64bit)
    libmimotestmi.so()(64bit)
    libmimotestmisrv.so()(64bit)
    libmodais.so()(64bit)
    libmodaissrv.so()(64bit)
    libmodam.so()(64bit)
    libmodamsrv.so()(64bit)
    libmodatv.so()(64bit)
    libmodatvsrv.so()(64bit)
    libmodchirpchat.so()(64bit)
    libmodchirpchatsrv.so()(64bit)
    libmodfreedv.so()(64bit)
    libmodfreedvsrv.so()(64bit)
    libmodieee_802_15_4.so()(64bit)
    libmodieee_802_15_4srv.so()(64bit)
    libmodnfm.so()(64bit)
    libmodnfmsrv.so()(64bit)
    libmodpacket.so()(64bit)
    libmodpacketsrv.so()(64bit)
    libmodssb.so()(64bit)
    libmodssbsrv.so()(64bit)
    libmodwfm.so()(64bit)
    libmodwfmsrv.so()(64bit)
    libnoisefigure.so()(64bit)
    libnoisefiguresrv.so()(64bit)
    liboutputaudio.so()(64bit)
    liboutputaudiosrv.so()(64bit)
    liboutputfileoutput.so()(64bit)
    liboutputfileoutputsrv.so()(64bit)
    liboutputhackrf.so()(64bit)
    liboutputhackrfsrv.so()(64bit)
    liboutputlocal.so()(64bit)
    liboutputlocalsrv.so()(64bit)
    liboutputplutosdr.so()(64bit)
    liboutputplutosdrsrv.so()(64bit)
    liboutputtestmosync.so()(64bit)
    liboutputtestmosyncsrv.so()(64bit)
    liboutputtestsink.so()(64bit)
    liboutputtestsinksrv.so()(64bit)
    liboutputusrp.so()(64bit)
    liboutputusrpsrv.so()(64bit)
    libplutosdrdevice.so()(64bit)
    libqrtplib.so()(64bit)
    libradioastronomy.so()(64bit)
    libradioastronomysrv.so()(64bit)
    libradioclock.so()(64bit)
    libradioclocksrv.so()(64bit)
    libsdrbase.so()(64bit)
    libsdrbench.so()(64bit)
    libsdrgui.so()(64bit)
    libsdrsrv.so()(64bit)
    libswagger.so()(64bit)
    libudpsink.so()(64bit)
    libudpsinksrv.so()(64bit)
    libudpsource.so()(64bit)
    libudpsourcesrv.so()(64bit)
    libusrpdevice.so()(64bit)
    libvorlocalizer.so()(64bit)
    libvorlocalizersrv.so()(64bit)
    sdrangel
    sdrangel(x86-64)

sdrangel-debuginfo:
    debuginfo(build-id)
    libantennatools.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libantennatoolssrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libaprs.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libaprssrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libbeamsteeringcwmod.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libbeamsteeringcwmodsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libchanalyzer.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodadsb.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodadsbsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodais.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodaissrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodam.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodamsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodatv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodbfm.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodbfmsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodchirpchat.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodchirpchatsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodfreedv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodfreedvsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodnfm.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodnfmsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodpacket.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodpacketsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodpager.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodpagersrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodssb.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodssbsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodvor.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodvorsc.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodvorscsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodvorsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodwfm.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libdemodwfmsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfcdhid.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfcdlib.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeatureafc.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeatureafcsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeatureais.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeatureaissrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturedemodanalyzer.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturedemodanalyzersrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturegs232controller.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturegs232controllersrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturepertester.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturepertestersrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturerigctlserver.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturerigctlserversrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturesimpleptt.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturesimplepttsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturestartracker.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfeaturestartrackersrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfilesink.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfilesinksrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfilesource.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfilesourcesrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfreqtracker.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libfreqtrackersrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libhackrfdevice.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libhttpserver.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputairspy.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputairspysrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputaudio.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputaudiosrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputfcdpro.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputfcdproplus.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputfcdproplussrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputfcdprosrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputfileinput.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputfileinputsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputhackrf.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputhackrfsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputkiwisdr.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputkiwisdrsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputlocal.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputlocalsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputplutosdr.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputplutosdrsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputrtlsdr.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputrtlsdrsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputtestsource.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputtestsourcesrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputusrp.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinputusrpsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libinterferometer.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libjogdialcontroller.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liblocalsink.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liblocalsinksrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liblocalsource.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liblocalsourcesrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liblogging.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmap.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmapsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmetisdevice.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmimometismiso.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmimometismisosrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmimoplutosdr.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmimoplutosdrsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmimotestmi.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmimotestmisrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodais.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodaissrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodam.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodamsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodatv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodatvsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodchirpchat.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodchirpchatsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodfreedv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodfreedvsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodieee_802_15_4.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodieee_802_15_4srv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodnfm.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodnfmsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodpacket.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodpacketsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodssb.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodssbsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodwfm.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libmodwfmsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libnoisefigure.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libnoisefiguresrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputaudio.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputaudiosrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputfileoutput.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputfileoutputsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputhackrf.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputhackrfsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputlocal.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputlocalsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputplutosdr.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputplutosdrsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputtestmosync.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputtestmosyncsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputtestsink.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputtestsinksrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputusrp.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    liboutputusrpsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libplutosdrdevice.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libqrtplib.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libradioastronomy.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libradioastronomysrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libradioclock.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libradioclocksrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libsdrbase.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libsdrbench.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libsdrgui.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libsdrsrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libswagger.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libudpsink.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libudpsinksrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libudpsource.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libudpsourcesrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libusrpdevice.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libvorlocalizer.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    libvorlocalizersrv.so-6.18.1-1.fc36.x86_64.debug()(64bit)
    sdrangel-debuginfo
    sdrangel-debuginfo(x86-64)

sdrangel-debugsource:
    sdrangel-debugsource
    sdrangel-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -L /home/reviewer/fedora/rawhide/2045294-serialdv/rpms -b 2045924
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: PHP, R, Haskell, Python, fonts, Ocaml, SugarActivity, Perl, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /home/reviewer/fedora/rawhide/2045294-serialdv/rpms/serialdv-devel-1.1.4-1.fc36.x86_64.rpm
    /home/reviewer/fedora/rawhide/2045294-serialdv/rpms/serialdv-debugsource-1.1.4-1.fc36.x86_64.rpm
    /home/reviewer/fedora/rawhide/2045294-serialdv/rpms/serialdv-1.1.4-1.fc36.x86_64.rpm
    /home/reviewer/fedora/rawhide/2045294-serialdv/rpms/serialdv-debuginfo-1.1.4-1.fc36.x86_64.rpm
Comment 7 Jaroslav Škarvada 2022-02-23 19:43:02 UTC 
(In reply to Petr Menšík from comment #3)
Thanks for the review.

Moving step-by-step :)
> fcdhid/hidapi.h seems to be ancient version [1.1] of today's hidapi [1.2],
> which has own hidapi-devel package ready on Fedora. Either it should declare
> bundled(hidapi), better it should be modified to work and link with hidapi
> package if possible. If not possible, it should describe briefly reason for
> it in spec. Ideally provides should also report bundled version, if upstream
> is able to provide it.
> 
Actually it's bundling qthid which is bundling hidapi :)

It seems it cannot be built with the upstream qthid, thus adding bundled(qthid) and I am trying to unbundle the hidapi.

> I think qrtplib subdirectory contains JRTPLIB, which should be declared by
> Provides: bundled(JRTPLIB) [2].
>
Added.
 
> httpserver contains part of QtWebApp, should Provides: bundled(QtWebApp) as
> well [3].
>
Added.
 
> Sources provide also rescuesdriq tool written in Go language. Might be built
> as well, but I admit I lack knowledge to build go project in proper way.
> That is purely optional.
> 
It's helper tool for repairing broken IQ files. It is not covered by the project CMake thus I think upstream doesn't want it to be installed by default, thus I will not package it.
Comment 8 Jaroslav Škarvada 2022-02-23 20:02:50 UTC 
(In reply to Petr Menšík from comment #4)
> Created attachment 1857573 [details]
> licensecheck.txt
> 
> License check detected quite a lot different licenses uses. Some are just
> few headers, like Apache 2.0 license. But MIT covers rtp part of quite a lot
> of files. I think all used licenses have to be noted in License: tag if they
> are used to build binary outputs.
> 
> It should be noted in spec which parts are covered by which license. Current
> GPLv3 license it not clearly enough, I am confident at least some of other
> licenses are used to produce binaries. It should be described which files
> are covered by which license. Details are in licensing guidelines [1].
> 
> 1.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> LicensingGuidelines/#_multiple_licensing_scenarios

Actually I can see (hopefully I haven't overseen anything :):
GPLv2+
GPLv3+
LGPLv2+
ASL 2.0
BSD
WTFPL
Boost
MIT

IMHO all are GPL compatible thus the resulting work can be released under the effective license GPLv3+. In Fedora in the License tag you can either use the effective license or in case you cannot evaluate it, you can list all licenses to be safe.
Comment 9 Jaroslav Škarvada 2022-02-23 20:12:40 UTC 
(In reply to Petr Menšík from comment #5)
> I would like SDR term explained in package description. I know it might be
> Software Defined Radio, but I guess just single line is not enough to
> describe GUI application with so many plugins. User should not guess what it
> does from main package description.
> 
> I think wiki would be good source for user descriptive text [1]. It seems no
> simple application, I would expect at least 3 lines describing who and for
> what can use it. I know it is highly technical application. Put please spend
> some words on it.
> 
> 1. https://github.com/f4exb/sdrangel/wiki/Quick-start

Hopefully improved. Please let me know in case it's still not good.
Comment 10 Jaroslav Škarvada 2022-02-23 21:33:40 UTC 
Created attachment 1863085 [details]
HIDAPI unbundling patch
Comment 11 Jaroslav Škarvada 2022-02-23 21:52:28 UTC 
Spec URL: https://jskarvad.fedorapeople.org/sdrangel/sdrangel.spec
SRPM URL: https://jskarvad.fedorapeople.org/sdrangel/sdrangel-6.19.1-1.fc34.src.rpm
Comment 12 Petr Menšík 2022-02-25 18:53:00 UTC 
Thanks for hidapi unbundling, it seems nice.

Description is much better, thank you for that. I had trouble understanding what it describes, but I think that is correct. If I do not understand the description, I would not need the package quite likely.

I think you can merge GPLv2+ and GPLv3+ licenses. LGPLv2+ is a bit different. But I do not think it is okay to omit ASL 2.0 and BSD and WTFPL and Boost and MIT. It is good they are compatible, but they are not very similar. I think all of them have to be mentioned in License: tag. I doubt many people analyze them in detail anyway, but it belongs there.

I am afraid you would still have to describe which files are covered by which license and notice all used in build. I think that is last remaining step in the review. Otherwise it is fine.
I think this is the mixed source scenario [1].

I would use
Source0:	%{url}/archive/v%{version}/%{name}-%{version}.tar.gz

It is shorter and reusable for (almost) any github project.

1. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_mixed_source_licensing_scenario
Comment 13 Jaroslav Škarvada 2022-03-10 21:30:00 UTC 
(In reply to Petr Menšík from comment #12)
> Thanks for hidapi unbundling, it seems nice.
>
Unbundled upstream.

> I think you can merge GPLv2+ and GPLv3+ licenses. LGPLv2+ is a bit
> different. But I do not think it is okay to omit ASL 2.0 and BSD and WTFPL
> and Boost and MIT. It is good they are compatible, but they are not very
> similar. I think all of them have to be mentioned in License: tag. I doubt
> many people analyze them in detail anyway, but it belongs there.
> 
> I am afraid you would still have to describe which files are covered by
> which license and notice all used in build. I think that is last remaining
> step in the review. Otherwise it is fine.
> I think this is the mixed source scenario [1].
> 
I followed the:
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F

I.e. I understand it that there are two possible options:
a) calculate the effective license, or
b) list all licenses used in the sources

I think the effective license is correct in this case (or at least I wasn't able to find anything that would dispute it)

> I would use
> Source0:	%{url}/archive/v%{version}/%{name}-%{version}.tar.gz
> 
Fixed
Comment 14 Jaroslav Škarvada 2022-03-10 21:30:44 UTC 
Spec URL: https://jskarvad.fedorapeople.org/sdrangel/sdrangel.spec
SRPM URL: https://jskarvad.fedorapeople.org/sdrangel/sdrangel-6.20.1-1.fc34.src.rpm
Comment 15 Petr Menšík 2022-03-11 12:29:23 UTC 
Okay, you have persuaded me. Spec is okay, passing the review. Thank you for your work!
Comment 16 Gwyn Ciesla 2022-03-11 21:15:53 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/sdrangel
Comment 17 Fedora Update System 2022-03-12 00:55:02 UTC 
FEDORA-2022-ef28d7ac21 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ef28d7ac21
Comment 18 Fedora Update System 2022-03-12 00:56:14 UTC 
FEDORA-2022-ef28d7ac21 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 19 Fedora Update System 2022-03-12 11:01:45 UTC 
FEDORA-2022-78a46c1b4e has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-78a46c1b4e
Comment 20 Fedora Update System 2022-03-12 11:02:44 UTC 
FEDORA-2022-78384f0a89 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-78384f0a89
Comment 21 Fedora Update System 2022-03-12 11:03:35 UTC 
FEDORA-2022-7ca97ca28d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7ca97ca28d
Comment 22 Fedora Update System 2022-03-12 22:35:55 UTC 
FEDORA-2022-78a46c1b4e has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-78a46c1b4e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-78a46c1b4e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 23 Fedora Update System 2022-03-13 17:44:05 UTC 
FEDORA-2022-78384f0a89 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-78384f0a89 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-78384f0a89

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 24 Fedora Update System 2022-03-13 18:38:17 UTC 
FEDORA-2022-7ca97ca28d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-7ca97ca28d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7ca97ca28d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 25 Fedora Update System 2022-03-22 03:18:06 UTC 
FEDORA-2022-7ca97ca28d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 26 Fedora Update System 2022-03-22 03:40:57 UTC 
FEDORA-2022-78384f0a89 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 27 Fedora Update System 2022-03-26 15:20:13 UTC 
FEDORA-2022-78a46c1b4e has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.