Bug 2046640

Summary: annobin: Rebuild plugin against gcc-12.0.1-0.3.fc36
Product: [Fedora] Fedora Reporter: Mamoru TASAKA <mtasaka>
Component: annobinAssignee: Nick Clifton <nickc>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: aoliva, dmalcolm, fweimer, jakub, jwakely, law, mpolacek, msebor, nickc, sipoyare
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: annobin-10.51-2.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-27 10:05:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
problematic source (not preprocessed)
none
preprocessed source anyway none

Description Mamoru TASAKA 2022-01-27 05:59:38 UTC 
Created attachment 1855699 [details]
problematic source (not preprocessed)

Description of problem:
rebuild of nbdkit-1.29.14-1.fc36 fails: https://koji.fedoraproject.org/koji/taskinfo?taskID=81983055 

Investigating this, I've found that actually the following command was failing (when executing configure)

$ gcc -c -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Werror  conftest.c
conftest.c: error: -D_FORTIFY_SOURCE not defined [-Werror]
cc1: all warnings being treated as errors

Looks like "-Wp,-D_FORTIFY_SOURCE=2" is not working??

Version-Release number of selected component (if applicable):
gcc-12.0.1-0.3.fc36.x86_64

How reproducible:
100%

Additional info:
So x86_64 fails, aarch64 also seems to be failing, but other arches seems successful...
I can attach preprocessed source if you want, however currently I am not sure if it is helpful because it looks like preprocessing are failing??
Comment 1 Mamoru TASAKA 2022-01-27 06:05:21 UTC 
Created attachment 1855700 [details]
preprocessed source anyway

Anyway attaching the result of:

$ gcc -E -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Werror  conftest.c > tmp.i
Comment 2 Florian Weimer 2022-01-27 09:27:53 UTC 
I believe annobin needs to be rebuilt. Due to a gcc ABI change, the plugin can no longer detect that the flag is present.
Comment 3 Florian Weimer 2022-01-27 10:05:58 UTC 
New build is in the buildroot.

Hopefully this was the last time the ABI skew happened. Nick's forthcoming changes should avoid this issue in the future.