Bug 2046780

Summary: octave-zmat: FTBFS in Fedora rawhide/f36
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: octave-zmatAssignee: Qianqian Fang <fangqq>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: fangqq, neuro-sig, sanjay.ankur
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: octave-zmat-0.9.8-6.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-25 16:42:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2117176, 1992484, 2045102    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2022-01-27 09:27:35 UTC
octave-zmat failed to build from source in Fedora rawhide/f36

https://koji.fedoraproject.org/koji/taskinfo?taskID=81984589


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
Please fix octave-zmat at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
octave-zmat will be orphaned. Before branching of Fedora 37,
octave-zmat will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2022-01-27 09:27:37 UTC
Created attachment 1855965 [details]
build.log

Comment 2 Fedora Release Engineering 2022-01-27 09:27:39 UTC
Created attachment 1855966 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2022-01-27 09:27:40 UTC
Created attachment 1855967 [details]
state.log

Comment 4 Ben Cotton 2022-02-08 20:39:41 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 5 Ankur Sinha (FranciscoD) 2022-05-09 13:49:59 UTC
Hi Qianqian:

Would you have time to look into this please? (Otherwise zmat won't be installable on F36)

Cheers,

Ankur

Comment 6 Qianqian Fang 2022-05-09 13:53:27 UTC
sorry, did not pay attention to my emails. sorry for the delay, will take a look and make a fix.

Comment 7 Ankur Sinha (FranciscoD) 2022-05-09 14:16:19 UTC
No worries. Please let us know if we can help with anything here. Hopefully it's a minor fix.

While you're at it, could you please double-check that the Fedora compiler flags are being used where necessary? I thought I looked at the build log here and they weren't being passed to the compiler. For example:

```
gcc -I../include -Ieasylzma -Ieasylzma/pavlov -Ilz4 -g -Wall -O3 -fPIC  -fPIC -c -o easylzma/pavlov/7zCrc.o easylzma/pavlov/7zCrc.c
```

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags

Thanks again for taking a look at this,

Ankur

Comment 8 Ankur Sinha (FranciscoD) 2022-08-15 08:48:43 UTC
Hi Qianqian,

How's this one going? Anything we can do to help?

Thanks,

Comment 9 Qianqian Fang 2022-08-15 16:12:51 UTC
sorry for the delay. I uploaded a patch (https://src.fedoraproject.org/rpms/octave-zmat/blob/f36/f/zmat-0.9.8-Octave7.patch), but somehow test build failed with patch error

https://koji.fedoraproject.org/koji/taskinfo?taskID=90835872

wondering if you can help me get around this. thanks

Comment 10 Ankur Sinha (FranciscoD) 2022-08-16 09:06:54 UTC
Sure---I've opened a PR for you now. It was just about using the right `-pX` argument for the patch:

https://src.fedoraproject.org/rpms/octave-zmat/pull-request/1

Please do remember to build for rawhide and f37 too (we need to ensure that version-release for rawhide >= that for f37 >= that for f36 >= that for f35 to maintain a clean upgrade path). You may need to do a `git checkout rawhide ; git pull --rebase` in your repo directory to get the new f37 branch etc.

Please do let us know if we can help with anything else,
Cheers.

Comment 11 Qianqian Fang 2022-08-16 15:11:28 UTC
thanks Ankur, I did not read the message carefully and ended up manually added your fix. f36 now builds fine

https://koji.fedoraproject.org/koji/buildinfo?buildID=2046771

I do have some trouble updating f36 or rawhide.

for f36, when I run "fedpkg update", typing in the bug number and password, it refuses to update with the below error message

$ fedpkg update
Could not execute update: Could not generate update request: Invalid request
A copy of the filled in template is saved as bodhi.template.last


for rawhide, after merging the changes, when I run scratch-build or build, it gave me the following error

$ fedpkg scratch-build --arches x86_64
Could not execute scratch_build: Unknown build target: rawhide-candidate


my toolchain might be old, do you know what this means? I remember these worked in the past.

Comment 12 Ankur Sinha (FranciscoD) 2022-08-17 08:17:15 UTC
That does seem to work for me, I just cloned the repo again:

$ git remote -v
origin  ssh://ankursinha.org/rpms/octave-zmat (fetch)
origin  ssh://ankursinha.org/rpms/octave-zmat (push)

$ git branch -v
* rawhide 535f253 merge with f36 with octave 7 patch

$ fedpkg scratch-build --arches=x86_64
Building octave-zmat-0.9.8-8.fc38 for rawhide
Created task: 90908719
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=90908719
Watching tasks (this may be safely interrupted)...
90908719 build (rawhide, /rpms/octave-zmat.git:535f2537d96f6574ab292fd107a2e9f38a9c5175): free


Could you try updating your system? Some of this tooling and its configuration has probably changed over time, so maybe you need the latest packages now. In the meantime, you should be able to use the Bodhi web interface to push updates too:

https://bodhi.fedoraproject.org/updates/new

Comment 13 Fedora Update System 2022-08-17 14:16:46 UTC
FEDORA-2022-747c692bd0 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-747c692bd0

Comment 14 Fedora Update System 2022-08-18 02:55:24 UTC
FEDORA-2022-747c692bd0 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-747c692bd0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-747c692bd0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Qianqian Fang 2022-08-18 13:36:34 UTC
thanks Ankur. after upgrading my tool version, I was able to build/update.

the bug should be fixed in f36/37 and rawhide.

Comment 16 Fedora Update System 2022-08-25 16:42:58 UTC
FEDORA-2022-747c692bd0 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.