Bug 204694

rpmlint on binary rpm reported
zvbi-0.2.22-1.fc6.i386.rpm 
I: zvbi checking
W: zvbi no-reload-entry /etc/rc.d/init.d/zvbid
In your init script (/etc/rc.d/init.d/your_file), you don't
have a 'reload' entry, which is necessary for good functionality.

W: zvbi incoherent-init-script-name zvbid
The init script name should be the same as the package name in lower case.

all above warnings have their descriptions given about how to solve them so
follow that.

> you don't have a 'reload' entry, which is necessary for good functionality.

And if the daemon doesn't support reload?  (alias it to restart?)

> The init script name should be the same as the package name in lower case

Not required, hence rpmlint marking this as a warning only, not an error.  IMO,
the script name should be the same as the daemon in question.

I can review this.  At first glance, package looks clean, just a few items off
the top of my head so far:

1.  in -devel: Change
Requires: zvbi = %{version}-%{release}
to the less error-prone:
Requires: %{name} = %{version}-%{release}

2. in %post/%postun fonts, change
/usr/bin/fc-cache %{_datadir}/fonts
to
/usr/bin/fc-cache %{_datadir}/fonts/%{name}
no need to tell fc-cache to reparse *all* of %_datadir/fonts, when we're only
interested in %_datadir/fonts/%name

3. -fonts: I'm pretty sure there's no real need for
Requires:           fontconfig
Requires(post):     /usr/bin/fc-cache
Requires(postun):   /usr/bin/fc-cache
The pkg doesn't *really* need/use fontconfig, and the calls to fc-cache in
scriptlets are wrapped with:
if [ -x /usr/bin/fc-cache ]; then
...
fi

Ammend item 2:
Only should change %post, I'd recommend:
/usr/bin/fc-cache -f  %{_datadir}/fonts/%{name}
shouldn't change %postun, since %{_datadir}/fonts/%{name} no longer exists

> W: zvbi no-reload-entry /etc/rc.d/init.d/zvbid
> In your init script (/etc/rc.d/init.d/your_file), you don't
> have a 'reload' entry, which is necessary for good functionality.
> 
> W: zvbi incoherent-init-script-name zvbid
> The init script name should be the same as the package name in lower case.
> 
> all above warnings have their descriptions given about how to solve them so
> follow that.

I'm in agreement with Rex on this one, I think calling the init script zvbi in 
this case doesn't make much sense, particularly when the daemon is really a 
small subset of the whole zvbi package, as opposed to being the primary 
function. It would require more than a simple namechange as the init script 
would need to be patched so that the 'subsystems' had matching names. Overkill 
I think for simply dropping the trailing 'd'. 

With wrt the reload option as it's considered optional I would rather not add 
it. IIRC primary reason for a reload option is to tell the daemon to reload its 
config files without quitting and starting again which is very useful for 
daemons that don't instantly stop or start such as squid, but in this case 
zvbid doesn't load configs.

Here's the latest version incorporating the three fixes from above.

Spec URL: http://dribble.org.uk/reviews/zvbi.spec
SRPM URL: http://dribble.org.uk/reviews/zvbi-0.2.22-2.src.rpm

Excellent, looks good, APPROVED.

Thanks for the review.

Package Change Request
======================
Package Name: zvbi
New Branches: el5 el6
Owners: buc

Git done (by process-git-requests).