Bug 2047467

Summary: [MTV][UI] Default pod network line is duplicated when using pre-defined mapping in plan wizard
Product: Migration Toolkit for Virtualization Reporter: Igor Braginsky <ibragins>
Component: User ExperienceAssignee: Mike Turley <mturley>
Status: CLOSED ERRATA QA Contact: Igor Braginsky <ibragins>
Severity: medium Docs Contact: Richard Hoch <rhoch>
Priority: high    
Version: 2.3.0CC: fbladilo, mturley
Target Milestone: ---Keywords: Regression
Target Release: 2.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-04 18:03:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
duplicated network none

Description Igor Braginsky 2022-01-27 21:32:56 UTC
Created attachment 1857214 [details]
duplicated network

Description of problem: default pod network line is duplicated when using pre-defined mapping in plan wizard


Version-Release number of selected component (if applicable): 2.3.0-16


How reproducible: 100%


Steps to Reproduce:
1. Create RHV provider (may be VMWare too)
2. Create network mapping for that provider
3. Start creating plan
4. On network mapping page select just created mapping

Actual results:
`Default pod network` line will be duplicated and shown twice

Expected results:
All networks should be shown once

Additional info:

Comment 1 Mike Turley 2022-02-17 14:53:52 UTC
Igor, do you have a cluster where this can be reproduced? I'm not seeing it locally (I see a different but related issue with the mapping items being blank)

Comment 2 Mike Turley 2022-02-28 18:22:50 UTC
Was able to reproduce this on the mig01 cluster.

It turns out that the behavior here is misleading, and there is not in fact a duplicate mapping line here, but two different networks of the same name being mapped. This PR fixes it by showing the path of the source networks to distinguish them: https://github.com/konveyor/forklift-ui/pull/925 (see more details in the PR for a full explanation).

Comment 3 Mike Turley 2022-03-01 16:44:15 UTC
Moving to MODIFIED, this was backported as part of a fast-forward merge from main to release-v2.3.0 (d040082)

Comment 4 Igor Braginsky 2022-03-03 09:57:48 UTC
Thanks, Mike, waiting for a new build to verify this bug

Comment 5 Igor Braginsky 2022-03-09 14:38:11 UTC
Validated on MTV-2.3.0-37, LGTM

Comment 9 errata-xmlrpc 2022-04-04 18:03:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.3.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:1183