Bug 2047670
| Summary: | Installer should pre-check that the hosted zone is not associated with the VPC and throw the error message. | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Manoj Hans <mhans> |
| Component: | Installer | Assignee: | John Hixson <jhixson> |
| Installer sub component: | openshift-installer | QA Contact: | Manoj Hans <mhans> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | medium | ||
| Priority: | medium | CC: | yunjiang |
| Version: | 4.10 | Keywords: | Regression |
| Target Milestone: | --- | ||
| Target Release: | 4.11.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: regression
Consequence: openshift-install would crash when using internal publishing strategy
Fix: when using internal publishing strategy, check if hosted zone is also empty
Result: openshift-install no longer crashes
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-08-10 10:44:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Manoj Hans
2022-01-28 09:29:43 UTC
This is a regression introduced in https://github.com/openshift/installer/pull/5189. There was a check added to ValidateForProvisioning to not run the validation when using the internal publishing strategy. https://github.com/openshift/installer/blob/f6ea846f7a8a2357191dd2e2c4cec5b73023d0f0/pkg/asset/installconfig/aws/validation.go#L351-L353 I have validated the bug using the provided PR but the below case is failing.
Verify that the hosted zone id should be valid.
create a install config and update:
baseDomain: mhans-41244.qe.devcluster.openshift.com
platform:
aws:
hostedZone: INVALID
subnets:
- subnet-0b8a9733d8a92a198
- subnet-03dc4fabb83e4f088
publish: Internal
Expected results:
Installer should throw this error message:
"failed to fetch Cluster: failed to fetch dependency of \"Cluster\": failed to generate asset \"Platform Provisioning Check\": aws.hostedZone: Invalid value: \"INVALID\": cannot find hosted zone"
Actual results:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x3306a4f]
goroutine 1 [running]:
github.com/openshift/installer/pkg/asset/installconfig/aws.isHostedZoneAssociatedWithVPC(0xc0007c3dd0, {0xc00020d140, 0x15})
/go/src/github.com/openshift/installer/pkg/asset/installconfig/aws/validation.go:491 +0x2f
github.com/openshift/installer/pkg/asset/installconfig/aws.validateHostedZone(0x4983f60, 0xc00048a208, {0xc0009c1530, 0x12}, 0x2388d95)
/go/src/github.com/openshift/installer/pkg/asset/installconfig/aws/validation.go:440 +0x168
github.com/openshift/installer/pkg/asset/installconfig/aws.ValidateForProvisioning(0xc001152230, 0xc0003fb200, 0xc00019c010)
/go/src/github.com/openshift/installer/pkg/asset/installconfig/aws/validation.go:372 +0x1e5
github.com/openshift/installer/pkg/asset/installconfig.(*PlatformProvisionCheck).Generate(0xc0001ae000, 0x5)
/go/src/github.com/openshift/installer/pkg/asset/installconfig/platformprovisioncheck.go:56 +0xd9
github.com/openshift/installer/pkg/asset/store.(*storeImpl).fetch(0xc0009bc4b0, {0x17dd7db0, 0x1b1e0c30}, {0x5301d54, 0x2})
/go/src/github.com/openshift/installer/pkg/asset/store/store.go:227 +0x604
github.com/openshift/installer/pkg/asset/store.(*storeImpl).fetch(0xc0009bc4b0, {0x17dd7b70, 0x1b190b50}, {0x0, 0x0})
/go/src/github.com/openshift/installer/pkg/asset/store/store.go:221 +0x759
github.com/openshift/installer/pkg/asset/store.(*storeImpl).Fetch(0x17e3a9f8, {0x17dd7b70, 0x1b190b50}, {0x1b1728a0, 0x8, 0x8})
/go/src/github.com/openshift/installer/pkg/asset/store/store.go:77 +0x48
main.runTargetCmd.func1({0x5301d3c, 0x1})
/go/src/github.com/openshift/installer/cmd/openshift-install/create.go:241 +0x116
main.runTargetCmd.func2(0x1b1784a0, {0x1b1e0c30, 0x0, 0x0})
/go/src/github.com/openshift/installer/cmd/openshift-install/create.go:268 +0xae
github.com/spf13/cobra.(*Command).execute(0x1b1784a0, {0x1b1e0c30, 0x0, 0x0})
/go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:860 +0x5f8
github.com/spf13/cobra.(*Command).ExecuteC(0xc000889680)
/go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:974 +0x3bc
github.com/spf13/cobra.(*Command).Execute(...)
/go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:902
main.installerMain()
/go/src/github.com/openshift/installer/cmd/openshift-install/main.go:60 +0x29e
main.main()
/go/src/github.com/openshift/installer/cmd/openshift-install/main.go:38 +0xff
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:5069 |