Bug 2048103

Summary:	python3-typer-cli provides python3dist(typer-cli) = 0
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-typer-cli	Assignee:	Ben Beasley <code>
Status:	CLOSED ERRATA	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	code
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-typer-cli-0.0.12-10.fc36 python-typer-cli-0.0.12-9.fc35 python-typer-cli-0.0.12-2.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-30 15:38:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2048077

Description Miro Hrončok 2022-01-29 12:26:40 UTC

The package python3-typer-cli has the following automatic provide:

  python3dist(typer-cli) = 0

It appears that the actual package version was lost during the packaging process. 

In most cases, this is caused by using a Source that misses version information, e.g. A GitHub tarball when the project uses setuptools_scm or pbr. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi

This bugzilla was created in a batch, so it does not have information about the exact cause for this package. If you need help figuring out why this happens in this particular package, feel free to ask.

Comment 1 Ben Beasley 2022-01-29 15:22:56 UTC

I’m away from a suitable computer at the moment, but I’ll investigate this in the next week or two.

Comment 2 Miro Hrončok 2022-01-29 15:48:28 UTC

https://github.com/tiangolo/typer-cli/blob/0.0.12/pyproject.toml has:

[tool.poetry]
version = "0"

[build-system]
requires = ["poetry>=0.12"]

[tool.poetry-version-plugin]
source = "init"

I guess the https://pypi.org/project/poetry-version-plugin/ is supposed to set the version properly but it is not listed in build-system.requires :/

Comment 3 Ben Beasley 2022-01-29 16:08:41 UTC

Furthermore, not only is it not yet packaged in Fedora, but it requires an unreleased version of poetry[1]. I think the best approach will be just to patch the version number into pyproject.toml in the conventional form[2].

I wish Python packaging would fail loudly rather than falling back to zero whenever something goes wrong with one of the various schemes for shuffling Python package version numbers around.

[1] https://github.com/tiangolo/poetry-version-plugin#how-to-use
[2] https://python-poetry.org/docs/pyproject/#version

Comment 4 Miro Hrončok 2022-01-29 17:32:11 UTC

> I think the best approach will be just to patch the version number into pyproject.toml in the conventional form.

I agree. I will send you a PR, so you can review it on your non-suitable computer.

> I wish Python packaging would fail loudly rather than falling back to zero...

This is a common problem with setuptools (see e.g. https://github.com/pypa/setuptools/issues/2329) but in this case, I'd say it does not fall back to zero, the zero is clearly there, set in the metadata.

Comment 5 Miro Hrončok 2022-01-29 17:38:40 UTC

https://src.fedoraproject.org/rpms/python-typer-cli/pull-request/1

Comment 6 Miro Hrončok 2022-01-29 21:12:57 UTC

> I wish Python packaging would fail loudly rather than falling back to zero...

We can do that at least in RPM packaging: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/K35JCFVJLETVUOICQM634OSYBYQ3Q2WQ/

Comment 7 Fedora Update System 2022-01-30 15:36:27 UTC

FEDORA-2022-e6c873c915 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e6c873c915

Comment 8 Fedora Update System 2022-01-30 15:38:25 UTC

FEDORA-2022-e6c873c915 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-01-31 18:38:00 UTC

FEDORA-2022-3fbd60e576 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3fbd60e576

Comment 10 Fedora Update System 2022-01-31 19:12:54 UTC

FEDORA-2022-b19d0471dc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b19d0471dc

Comment 11 Fedora Update System 2022-02-01 01:06:28 UTC

FEDORA-2022-b19d0471dc has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-b19d0471dc`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b19d0471dc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-02-01 02:00:06 UTC

FEDORA-2022-3fbd60e576 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-3fbd60e576`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3fbd60e576

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-02-09 01:17:42 UTC

FEDORA-2022-3fbd60e576 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-02-09 02:07:48 UTC

FEDORA-2022-b19d0471dc has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.