Bug 2048153

Summary:	Review Request: rust-libspa-sys - Rust FFI bindings for libspa
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-02-01 18:09:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2048154, 2048156, 2048157

Description Michel Lind 2022-01-29 19:40:27 UTC

Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-libspa-sys.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-libspa-sys-0.4.1-1.fc35.src.rpm
Description:  Rust FFI bindings for libspa.
Fedora Account System Username: salimma

Comment 1 Neal Gompa 2022-01-29 20:02:10 UTC

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

Comment 2 Michel Lind 2022-01-29 20:13:44 UTC

Thanks!

specs on  master [?] via 🌙 v5.4.3
❯ fedpkg request-repo rust-libspa-sys 2048153
https://pagure.io/releng/fedora-scm-requests/issue/41510

specs on  master [?] via 🌙 v5.4.3 took 3s
❯ fedpkg request-branch --repo rust-libspa-sys --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/41511
https://pagure.io/releng/fedora-scm-requests/issue/41512

Comment 3 Gwyn Ciesla 2022-01-31 17:49:49 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libspa-sys

Comment 4 Fedora Update System 2022-02-01 18:04:35 UTC

FEDORA-2022-9b7fe450fe has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9b7fe450fe

Comment 5 Fedora Update System 2022-02-01 18:05:51 UTC

FEDORA-2022-be12c06331 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-be12c06331

Comment 6 Fedora Update System 2022-02-01 18:09:32 UTC

FEDORA-2022-be12c06331 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2022-02-02 16:37:32 UTC

FEDORA-2022-9b7fe450fe has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-9b7fe450fe \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9b7fe450fe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-02-03 02:08:20 UTC

FEDORA-2022-9b7fe450fe has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fabio Valentini 2022-02-12 21:22:58 UTC

This package should not have been approved as-is:
There's no license file in the upstream sources, and not in the package, but the MIT license requires this.

This issue should have been reported upstream, and the license file from the upstream git repo included until it is included in redistributed sources.

I'm working on this package anyway, so I'll fix this with the next update, but please, next time, be more thorough with the review.