Bug 2048558

Summary: ipa-join tests are failing due to changes in expected output
Product: Red Hat Enterprise Linux 8 Reporter: Sudhir Menon <sumenon>
Component: ipaAssignee: Florence Blanc-Renaud <frenaud>
Status: CLOSED ERRATA QA Contact: ipa-qe <ipa-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.6CC: rcritten, rjeffman, ssidhaye, tscherf
Target Milestone: rcKeywords: Regression, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: idm-client-8060020220221131046.7c4ef452 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2051844 (view as bug list) Environment:
Last Closed: 2022-05-10 14:09:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2051844    

Description Sudhir Menon 2022-01-31 14:11:44 UTC
Description of problem: ipa-join tests are failing due to changes in expected output

Version-Release number of selected component (if applicable):
ipa-server-4.9.8-2.module+el8.6.0+13621+937b8cd9.x86_64


How reproducible: Always.

Steps to Reproduce:
1. ipa-join --hostname=ip-addr.testrealm.test  --server=No.Such.IPA.Server.Domain.com

Actual results:
[root@server log]# ipa-join --hostname=ip-addr.testrealm.test  --server=No.Such.IPA.Server.Domain.com
[root@server log]# echo $?
17

Expected results:
[HTTP POST to URL 'https://No.Such.IPA.Server.Domain.com:443/ipa/xml' failed.  libcurl failed even to execute the HTTP transaction, explaining:  SSL certificate problem: unable to get local issuer certificate]

Additional info:

Comment 2 Rob Crittenden 2022-01-31 15:03:56 UTC
The reproduction steps are insufficient. ipa-join requires either a password or a valid ticket in order to proceed. What is the invocation that returns no data at all?

Is any pre-setup done on the client such as pre-positioning /etc/ipa/ca.crt?

Comment 3 Florence Blanc-Renaud 2022-01-31 16:18:22 UTC
It looks like the test is doing the following, but @sumenon please confirm:
ipa-client-install
kinit admin
ipa host-del <client> (to un-enroll)
ipa-join --hostname <client> --server=No.Such.IPA.Server.Domain.com

and the test expects ipa-join to exit on failure (ret code =17) + print a message.

The message is not printed any more.

Comment 4 Florence Blanc-Renaud 2022-01-31 16:54:04 UTC
In RHEL 8.4, a message was printed, and the code was build with this macro in the spec file:
%bcond_without ipa_join_xml
meaning that by default, with_ipa_join_xml is set => ipa join is using XML-RPC.

In RHEL 8.5, no message is printed, the code was built with this macro in the spec file:
%bcond_with ipa_join_xml
meaning that by default, without_ipa_join_xml is set -> ipa join is using JSON-RPC.

The code for JSON-RPC is probably missing the part printing the error message to stdout.

Comment 5 Rob Crittenden 2022-01-31 19:36:22 UTC
The error is going to be different because the transports are different, but currently the JSON-based code will only display the error when in debug mode (-d):

# ipa-join -d --server No.such.domain
JSON-RPC request:
{"method": "join", "params": [["client.example.test"], {"nsosversion": "4.18.0-359.el8.x86_64", "nshardwareplatform": "x86_64"}]}
* Could not resolve host: No.such.domain
* Closing connection 0
JSON-RPC call failed: Couldn't resolve host name

Comment 6 Rob Crittenden 2022-01-31 22:28:05 UTC
Upstream ticket:
https://pagure.io/freeipa/issue/9103

Comment 7 Rob Crittenden 2022-02-04 18:30:35 UTC
Fixed upstream
master:
https://pagure.io/freeipa/c/3c1f4ba9956d920c0251525419d0dff3d8bf1bb3

Comment 8 Florence Blanc-Renaud 2022-02-07 08:17:40 UTC
Fixed upstream
ipa-4-9:
https://pagure.io/freeipa/c/7c5540bb47799b4db95673d22f61995ad5c56440

Comment 9 Florence Blanc-Renaud 2022-02-07 08:19:27 UTC
Note to QE: please pay attention to #c5: the output is going to be different (JSON-RPC is used instead of XML-RPC and the exact error message is likely to differ). The tests will have to be adapted.

Comment 17 Sumedh Sidhaye 2022-02-23 17:17:24 UTC
Automated run results:


Packages used :
ipa-client-4.9.8-6.module+el8.6.0+14224+4c38d4ea.x86_64
ipa-client-common-4.9.8-6.module+el8.6.0+14224+4c38d4ea.noarch
ipa-common-4.9.8-6.module+el8.6.0+14224+4c38d4ea.noarch
ipa-healthcheck-0.7-10.module+el8.6.0+14292+18b36d36.noarch
ipa-healthcheck-core-0.7-10.module+el8.6.0+14292+18b36d36.noarch
ipa-selinux-4.9.8-6.module+el8.6.0+14300+0c339766.noarch
ipa-server-4.9.8-6.module+el8.6.0+14224+4c38d4ea.x86_64
ipa-server-common-4.9.8-6.module+el8.6.0+14224+4c38d4ea.noarch
ipa-server-dns-4.9.8-6.module+el8.6.0+14224+4c38d4ea.noarch



Compose :
http://download-node-02.eng.bos.redhat.com/nightly/rhel-8/RHEL-8/RHEL-8.6.0-20220223.0/compose/AppStream/x86_64/os/Packages/


Test Report:

2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos] ====================================== Final Report =======================================
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]             Test Date: Wed Feb 23 12:06:39 EST 2022         
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]                Total : [37]       
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]                Passed: [37]        
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]                Failed: [0]        
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]            Unfinished: [0]  
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]                Abort : [0]       
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]                Crash : [0]     
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]  +-----------------------------[RPMs & OS: [RedHat - x86_64]-----------------------------+
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos] |       ipa-client-4.9.8-6.module+el8.6.0+14224+4c38d4ea.x86_64
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos] |       ipa-client-common-4.9.8-6.module+el8.6.0+14224+4c38d4ea.noarch
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos] |       sssd-ipa-2.6.2-3.el8.x86_64
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos] ------------------------------------------------------------------------------------------
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]  +-----------------------------------------------------------------------------------------+
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]      Test:[/ipa-server/rhel80/ipa-join/root]: [ Pass(37/37): 100% ] 
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]  +-----------------------------------------------------------------------------------------+
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]  +----------------------------------------------------------------------+
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]                     Fail / unfinished / ABORT [ Fail(0/37): 0% ]
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos]  +----------------------------------------------------------------------+
2022-02-23T17:06:40+0000 [ip-10-0-203-137.rhos] =========================== end of report [/tmp/rhts.report.18458.txt]===============================

Based on above observations marking bugzilla verified.

Comment 21 errata-xmlrpc 2022-05-10 14:09:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (idm:client and idm:DL1 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:1884