Bug 2049428

Summary: pyodbc fails to build with Python 3.11: error: PyUnicode_EncodeUTF8 was not declared in this scope
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: pyodbcAssignee: Ondřej Sloup <osloup>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fjanus, hhorak, mhroncok, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-29 10:15:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2016048, 2045102, 2045109, 2098773, 2098814, 2099119    

Description Tomáš Hrnčiar 2022-02-02 09:14:50 UTC
pyodbc fails to build with Python 3.11.0a4.

src/cnxninfo.cpp:45:18: error: ‘PyUnicode_EncodeUTF8’ was not declared in this scope; did you mean ‘PyUnicode_DecodeUTF8’?
   45 |     Object bytes(PyUnicode_EncodeUTF8(PyUnicode_AS_UNICODE(p), PyUnicode_GET_SIZE(p), 0));
      |                  ^~~~~~~~~~~~~~~~~~~~
      |                  PyUnicode_DecodeUTF8

https://docs.python.org/3.11/whatsnew/3.11.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/03272044-pyodbc/

For all our attempts to build pyodbc with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/pyodbc/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Filip Januš 2022-02-03 08:43:49 UTC
In the upstream, there is already a fix[1] waiting for merge.

[1] https://github.com/mkleehammer/pyodbc/pull/792

Comment 2 Ben Cotton 2022-02-08 20:18:16 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 3 Miro Hrončok 2022-06-20 10:16:10 UTC
*** Bug 2098791 has been marked as a duplicate of this bug. ***

Comment 4 Miro Hrončok 2022-06-20 11:44:23 UTC
(In reply to Filip Januš from comment #1)
> In the upstream, there is already a fix[1] waiting for merge.
> 
> [1] https://github.com/mkleehammer/pyodbc/pull/792

It has been merged, could you please backport it?

Comment 5 Ondřej Sloup 2022-06-28 09:47:08 UTC
Investigating if the issue was resolved by merge.

Comment 6 Ondřej Sloup 2022-06-28 16:15:14 UTC
The issue was resolved with the specified pull request, and the patch file was created into the current version.
https://src.fedoraproject.org/rpms/pyodbc/pull-request/3

Comment 8 Filip Januš 2022-06-29 10:15:00 UTC
build passed
https://koji.fedoraproject.org/koji/taskinfo?taskID=88880509