Bug 2049678

Summary: sphinxbase fails to build with Python 3.11: error: two or more data types in declaration specifiers
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: sphinxbaseAssignee: W. Michael Petullo <redhat>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: mhroncok, mike, pviktori, redhat, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-02-11 20:11:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2016048    

Description Tomáš Hrnčiar 2022-02-02 14:32:22 UTC
sphinxbase fails to build with Python 3.11.0a4.

In file included from /usr/include/python3.11/cpython/pystate.h:5,
                 from /usr/include/python3.11/pystate.h:135,
                 from /usr/include/python3.11/Python.h:76,
                 from sphinxbase_wrap.c:11:
sphinxbase_wrap.c:16:13: error: two or more data types in declaration specifiers
   16 | typedef int bool;
      |             ^~~~
sphinxbase_wrap.c:16:1: warning: useless type name in empty declaration
   16 | typedef int bool;
      | ^~~~~~~

https://docs.python.org/3.11/whatsnew/3.11.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/03272602-sphinxbase/

For all our attempts to build sphinxbase with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/sphinxbase/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2022-02-08 20:19:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 2 W. Michael Petullo 2022-02-11 20:11:49 UTC
My guess is that one of the Python header files started including stdbool.h, and thus the type bool conflicts with the name bool in:

typedef int bool;

The offending code is generated using swig.

I added a patch that removes the definition of bool and instead includes stdbool.h to make use of the system definition. See also https://github.com/cmusphinx/sphinxbase/pull/90.

Comment 3 Petr Viktorin (pviktori) 2022-02-14 09:29:54 UTC
Thanks!

We might want to avoid this in Python headers, too. I filed https://bugs.python.org/issue46748