Bug 2049790

Summary: Add error handling for GetCurrentStorageClusterRef
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: Pranshu Srivastava <prasriva>
Component: odf-drAssignee: Pranshu Srivastava <prasriva>
odf-dr sub component: multicluster-orchestrator QA Contact: Pratik Surve <prsurve>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: unspecified CC: kramdoss, madam, muagarwa, nberry, ocs-bugs, odf-bz-bot, uchapaga
Version: 4.10   
Target Milestone: ---   
Target Release: ODF 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.10.0-141 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-13 18:52:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pranshu Srivastava 2022-02-02 17:18:07 UTC 
Description of problem (please be detailed as possible and provide log
snippests): Add error handling for GetCurrentStorageClusterRef method that would otherwise cause a nil pointer dereference.


Version of all relevant components (if applicable): ODF 4.10


Can this issue reproducible? Yes.

Steps to Reproduce:
1. Deploy DR cluster
2. Deploy ODF over them
3. Create multiclusteroperator
4. Create mirror peer


Actual results: In cases when spoke cluster name does not match any managed cluster, we need to return an error and handle it in the caller. Failing to do so will create nil pointer exception and program crashes.


Expected results: It should error out and reconcile again.
Comment 3 umanga 2022-02-03 05:24:31 UTC 
This is a known corner case that causes pod to terminate when incorrect MirrorPeer CR is created. Adding devel_ack+ .
Comment 11 errata-xmlrpc 2022-04-13 18:52:48 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.10.0 enhancement, security & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1372