Bug 2050092

Summary: python-numpy-stl fails to build with Python 3.11: TypeError: 'float' object cannot be interpreted as an integer
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-numpy-stlAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mhroncok, python-sig, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-02-03 13:01:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2016048    

Description Tomáš Hrnčiar 2022-02-03 08:53:57 UTC
python-numpy-stl fails to build with Python 3.11.0a4.


=================================== FAILURES ===================================
_______________________________ test_main[False] _______________________________

ascii_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_ascii/HalfDonut.stl'
binary_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_binary/HalfDonut.stl'
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_main_False_0')
speedups = False

    def test_main(ascii_file, binary_file, tmpdir, speedups):
        original_argv = sys.argv[:]
        args_pre = ['stl']
        args_post = [str(tmpdir.join('output.stl'))]
    
        if not speedups:
            args_pre.append('-s')
    
        try:
            sys.argv[:] = args_pre + [ascii_file] + args_post
>           main.main()

tests/test_commandline.py:16: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
stl/main.py:48: in main
    name = _get_name(args)
stl/main.py:32: in _get_name
    'numpy-stl-%06d' % random.randint(0, 1e6),
/usr/lib64/python3.11/random.py:330: in randint
    return self.randrange(a, b+1)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <random.Random object at 0x55774b8355d0>, start = 0, stop = 1000001.0
step = 1

    def randrange(self, start, stop=None, step=_ONE):
        """Choose a random item from range(stop) or range(start, stop[, step]).
    
        Roughly equivalent to ``choice(range(start, stop, step))``
        but supports arbitrarily large ranges and is optimized
        for common cases.
    
        """
    
        # This code is a bit messy to make it fast for the
        # common case while still doing adequate error checking.
        istart = _index(start)
        if stop is None:
            # We don't check for "step != 1" because it hasn't been
            # type checked and converted to an integer yet.
            if step is not _ONE:
                raise TypeError('Missing a non-None stop argument')
            if istart > 0:
                return self._randbelow(istart)
            raise ValueError("empty range for randrange()")
    
        # Stop argument supplied.
>       istop = _index(stop)
E       TypeError: 'float' object cannot be interpreted as an integer

/usr/lib64/python3.11/random.py:306: TypeError
_______________________________ test_main[True] ________________________________

ascii_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_ascii/HalfDonut.stl'
binary_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_binary/HalfDonut.stl'
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_main_True_0')
speedups = True

    def test_main(ascii_file, binary_file, tmpdir, speedups):
        original_argv = sys.argv[:]
        args_pre = ['stl']
        args_post = [str(tmpdir.join('output.stl'))]
    
        if not speedups:
            args_pre.append('-s')
    
        try:
            sys.argv[:] = args_pre + [ascii_file] + args_post
>           main.main()

tests/test_commandline.py:16: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
stl/main.py:48: in main
    name = _get_name(args)
stl/main.py:32: in _get_name
    'numpy-stl-%06d' % random.randint(0, 1e6),
/usr/lib64/python3.11/random.py:330: in randint
    return self.randrange(a, b+1)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <random.Random object at 0x55774b8355d0>, start = 0, stop = 1000001.0
step = 1

    def randrange(self, start, stop=None, step=_ONE):
        """Choose a random item from range(stop) or range(start, stop[, step]).
    
        Roughly equivalent to ``choice(range(start, stop, step))``
        but supports arbitrarily large ranges and is optimized
        for common cases.
    
        """
    
        # This code is a bit messy to make it fast for the
        # common case while still doing adequate error checking.
        istart = _index(start)
        if stop is None:
            # We don't check for "step != 1" because it hasn't been
            # type checked and converted to an integer yet.
            if step is not _ONE:
                raise TypeError('Missing a non-None stop argument')
            if istart > 0:
                return self._randbelow(istart)
            raise ValueError("empty range for randrange()")
    
        # Stop argument supplied.
>       istop = _index(stop)
E       TypeError: 'float' object cannot be interpreted as an integer

/usr/lib64/python3.11/random.py:306: TypeError
_______________________________ test_args[False] _______________________________

ascii_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_ascii/HalfDonut.stl'
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_args_False_0')

    def test_args(ascii_file, tmpdir):
        parser = main._get_parser('')
    
        def _get_name(*args):
            return main._get_name(parser.parse_args(list(map(str, args))))
    
>       assert _get_name('--name', 'foobar') == 'foobar'

tests/test_commandline.py:33: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_commandline.py:31: in _get_name
    return main._get_name(parser.parse_args(list(map(str, args))))
stl/main.py:32: in _get_name
    'numpy-stl-%06d' % random.randint(0, 1e6),
/usr/lib64/python3.11/random.py:330: in randint
    return self.randrange(a, b+1)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <random.Random object at 0x55774b8355d0>, start = 0, stop = 1000001.0
step = 1

    def randrange(self, start, stop=None, step=_ONE):
        """Choose a random item from range(stop) or range(start, stop[, step]).
    
        Roughly equivalent to ``choice(range(start, stop, step))``
        but supports arbitrarily large ranges and is optimized
        for common cases.
    
        """
    
        # This code is a bit messy to make it fast for the
        # common case while still doing adequate error checking.
        istart = _index(start)
        if stop is None:
            # We don't check for "step != 1" because it hasn't been
            # type checked and converted to an integer yet.
            if step is not _ONE:
                raise TypeError('Missing a non-None stop argument')
            if istart > 0:
                return self._randbelow(istart)
            raise ValueError("empty range for randrange()")
    
        # Stop argument supplied.
>       istop = _index(stop)
E       TypeError: 'float' object cannot be interpreted as an integer

/usr/lib64/python3.11/random.py:306: TypeError
_______________________________ test_args[True] ________________________________

ascii_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_ascii/HalfDonut.stl'
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_args_True_0')

    def test_args(ascii_file, tmpdir):
        parser = main._get_parser('')
    
        def _get_name(*args):
            return main._get_name(parser.parse_args(list(map(str, args))))
    
>       assert _get_name('--name', 'foobar') == 'foobar'

tests/test_commandline.py:33: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/test_commandline.py:31: in _get_name
    return main._get_name(parser.parse_args(list(map(str, args))))
stl/main.py:32: in _get_name
    'numpy-stl-%06d' % random.randint(0, 1e6),
/usr/lib64/python3.11/random.py:330: in randint
    return self.randrange(a, b+1)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <random.Random object at 0x55774b8355d0>, start = 0, stop = 1000001.0
step = 1

    def randrange(self, start, stop=None, step=_ONE):
        """Choose a random item from range(stop) or range(start, stop[, step]).
    
        Roughly equivalent to ``choice(range(start, stop, step))``
        but supports arbitrarily large ranges and is optimized
        for common cases.
    
        """
    
        # This code is a bit messy to make it fast for the
        # common case while still doing adequate error checking.
        istart = _index(start)
        if stop is None:
            # We don't check for "step != 1" because it hasn't been
            # type checked and converted to an integer yet.
            if step is not _ONE:
                raise TypeError('Missing a non-None stop argument')
            if istart > 0:
                return self._randbelow(istart)
            raise ValueError("empty range for randrange()")
    
        # Stop argument supplied.
>       istop = _index(stop)
E       TypeError: 'float' object cannot be interpreted as an integer

/usr/lib64/python3.11/random.py:306: TypeError
______________________________ test_ascii[False] _______________________________

binary_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_binary/HalfDonut.stl'
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_ascii_False_0')
speedups = False

    def test_ascii(binary_file, tmpdir, speedups):
        original_argv = sys.argv[:]
        try:
            sys.argv[:] = [
                'stl',
                '-s' if not speedups else '',
                binary_file,
                str(tmpdir.join('ascii.stl')),
            ]
            try:
>               main.to_ascii()

tests/test_commandline.py:49: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
stl/main.py:69: in to_ascii
    name = _get_name(args)
stl/main.py:32: in _get_name
    'numpy-stl-%06d' % random.randint(0, 1e6),
/usr/lib64/python3.11/random.py:330: in randint
    return self.randrange(a, b+1)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <random.Random object at 0x55774b8355d0>, start = 0, stop = 1000001.0
step = 1

    def randrange(self, start, stop=None, step=_ONE):
        """Choose a random item from range(stop) or range(start, stop[, step]).
    
        Roughly equivalent to ``choice(range(start, stop, step))``
        but supports arbitrarily large ranges and is optimized
        for common cases.
    
        """
    
        # This code is a bit messy to make it fast for the
        # common case while still doing adequate error checking.
        istart = _index(start)
        if stop is None:
            # We don't check for "step != 1" because it hasn't been
            # type checked and converted to an integer yet.
            if step is not _ONE:
                raise TypeError('Missing a non-None stop argument')
            if istart > 0:
                return self._randbelow(istart)
            raise ValueError("empty range for randrange()")
    
        # Stop argument supplied.
>       istop = _index(stop)
E       TypeError: 'float' object cannot be interpreted as an integer

/usr/lib64/python3.11/random.py:306: TypeError
______________________________ test_binary[False] ______________________________

ascii_file = '/builddir/build/BUILD/numpy-stl-2.16.3/tests/stl_ascii/HalfDonut.stl'
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_binary_False_0')
speedups = False

    def test_binary(ascii_file, tmpdir, speedups):
        original_argv = sys.argv[:]
        try:
            sys.argv[:] = [
                'stl',
                '-s' if not speedups else '',
                ascii_file,
                str(tmpdir.join('binary.stl')),
            ]
            try:
>               main.to_binary()

tests/test_commandline.py:66: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
stl/main.py:81: in to_binary
    name = _get_name(args)
stl/main.py:32: in _get_name
    'numpy-stl-%06d' % random.randint(0, 1e6),
/usr/lib64/python3.11/random.py:330: in randint
    return self.randrange(a, b+1)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <random.Random object at 0x55774b8355d0>, start = 0, stop = 1000001.0
step = 1

    def randrange(self, start, stop=None, step=_ONE):
        """Choose a random item from range(stop) or range(start, stop[, step]).
    
        Roughly equivalent to ``choice(range(start, stop, step))``
        but supports arbitrarily large ranges and is optimized
        for common cases.
    
        """
    
        # This code is a bit messy to make it fast for the
        # common case while still doing adequate error checking.
        istart = _index(start)
        if stop is None:
            # We don't check for "step != 1" because it hasn't been
            # type checked and converted to an integer yet.
            if step is not _ONE:
                raise TypeError('Missing a non-None stop argument')
            if istart > 0:
                return self._randbelow(istart)
            raise ValueError("empty range for randrange()")
    
        # Stop argument supplied.
>       istop = _index(stop)
E       TypeError: 'float' object cannot be interpreted as an integer

/usr/lib64/python3.11/random.py:306: TypeError
=========================== short test summary info ============================
FAILED tests/test_commandline.py::test_main[False] - TypeError: 'float' objec...
FAILED tests/test_commandline.py::test_main[True] - TypeError: 'float' object...
FAILED tests/test_commandline.py::test_args[False] - TypeError: 'float' objec...
FAILED tests/test_commandline.py::test_args[True] - TypeError: 'float' object...
FAILED tests/test_commandline.py::test_ascii[False] - TypeError: 'float' obje...
FAILED tests/test_commandline.py::test_binary[False] - TypeError: 'float' obj...
=================== 6 failed, 94 passed, 4 skipped in 3.97s ====================

https://docs.python.org/3.11/whatsnew/3.11.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/03271594-python-numpy-stl/

For all our attempts to build python-numpy-stl with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/python-numpy-stl/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2022-02-03 10:03:37 UTC
Trying to reproduce upstream with tox, but the numpy+cython setup will likely fail.

I get:

  numpy/random/_mt19937.c:6840:19: error: ‘_PyErr_StackItem’ {aka ‘struct _err_stackitem’} has no member named ‘exc_traceback’

Comment 2 Miro Hrončok 2022-02-03 10:10:22 UTC
$ python3.10
>>> import random
>>> random.randint(0, 1e6)
516518

$ python3.11
>>> import random
>>> random.randint(0, 1e6)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python3.11/random.py", line 330, in randint
    return self.randrange(a, b+1)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/random.py", line 306, in randrange
    istop = _index(stop)
            ^^^^^^^^^^^^
TypeError: 'float' object cannot be interpreted as an integer

Comment 3 Miro Hrončok 2022-02-03 10:40:32 UTC
https://bugs.python.org/issue42222
https://github.com/python/cpython/commit/5afa0a411243210a30526c7459a0ccff5cb88494

randrange: Remove deprecated support for non-integer values

Comment 4 Miro Hrončok 2022-02-03 10:53:15 UTC
The randint/randrange change in Python violates Python's own policy for incompatible changes. I've asked the maintainer to revert it: https://bugs.python.org/issue46624