Bug 205031
| Summary: | Review Request: python-telepathy - Python libraries for Telepathy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
| Component: | Package Review | Assignee: | Sander Hoentjen <sander> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bdpepple, pbrobinson, sander, sebastian, tomeu |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-08 13:52:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 205343 | ||
|
Description
Brian Pepple
2006-09-02 18:06:33 UTC
*** Bug 205066 has been marked as a duplicate of this bug. *** Spec file is basically the same as I had, only you used the correct naming for Fedora. Also the URL *could* be changed to http://telepathy.freedesktop.org/wiki/TelepathyPython but that doesn't really matter. I also had the examples packaged under docs, but I am not even sure if that is a good thing. I would approve, but I am still not in fedorabugs so I'll leave the review part until i am, maybe someone else will pick up before then. GOOD - package meets naming and packaging guidelines. - specfile is properly named, is cleanly written and uses macros consistently. - dist tag is present. - build root is correct. - license field matches the actual license. - license is open source-compatible. License text included in package. - source files match upstream: 39a07295c78699da6efc1e4638c53688 - BuildRequires are proper. - package builds in mock (x86_64). - rpmlint is silent. - final provides and requires are sane: python-telepathy-0.13.2-1.fc6.noarch.rpm python-telepathy = 0.13.2-1.fc6 = python(abi) = 2.4 - no shared libraries are present. - package is not relocatable. - owns the directories it creates. - doesn't own any directories it shouldn't. - no duplicates in %files. - file permissions are appropriate. - %clean is present. - no scriptlets present. - code, not content. - documentation is small, so no -docs subpackage is necessary. - %docs are not necessary for the proper functioning of the package. - no headers. - no pkgconfig files. - no libtool .la droppings. - not a GUI app. - not a web app. APPROVED Package Change Request ====================== Package Name: python-telepathy New Branches: F-8 cvs done. New Package CVS Request ======================= Package Name: python-telepathy Short Description: Python bindings for Telepathy Owners: morgan.collett, tomeu Branches: OLPC-3 cvs done. Package Change Request ====================== Package Name: python-telepathy New Branches: EL-6 Owners: pbrobinson sdz Package Change Request ====================== Package Name: python-telepathy New Branches: EL-6 Owners: pbrobinson sdz bpepple I emailed Brian and he said that it would probably be better if someone else maintained the EPEL branches, since he's not currently running any systems that use EPEL. If you need additional confirmation, can you comment here please, Brian? For background, we're interested in maintaining these in EPEL since they are dependencies of the Sugar Environment, which we're trying to push into EPEL. CVS done (by process-cvs-requests.py). |