Bug 2050421

Summary:	RFE: have mpatchconf handle options as well (e.g. find_multipaths_timeout)
Product:	Red Hat Enterprise Linux 9	Reporter:	Ben Marzinski <bmarzins>
Component:	device-mapper-multipath	Assignee:	Ben Marzinski <bmarzins>
Status:	CLOSED ERRATA	QA Contact:	Lin Li <lilin>
Severity:	low	Docs Contact:
Priority:	low
Version:	9.0	CC:	agk, bmarzins, heinzm, lilin, msnitzer, prajnoha, rmetrich, zkabelac
Target Milestone:	rc	Keywords:	FutureFeature, Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	device-mapper-multipath-0.8.7-5.el9	Doc Type:	Enhancement
Doc Text:	Feature: mpathconf can now add, change, or remove any /etc/mulitpath.conf defaults section option using the new --option command Reason: Some users want a command to update /etc/multipath.conf without having to edit the file manually. Result: Users no longer need to manually edit /etc/multipath.conf to add, change or remove defaults section options.	Story Points:	---
Clone Of:	1981240	Environment:
Last Closed:	2022-05-17 15:56:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1981240
Bug Blocks:

Description Ben Marzinski 2022-02-03 22:43:19 UTC

+++ This bug was initially created as a clone of Bug #1981240 +++

Description of problem:

This is a continuation of BZ #1979470. It would be nice if mpathconf could let the user specify options, in this particular case find_multipaths_timeout.
Indeed it's not easy to automate this task using a sed script and doing this cleanly, the only solution I see is using an additional drop-in file /etc/multipath.conf.d/xxx.conf

Version-Release number of selected component (if applicable):

device-mapper-multipath-0.8.4-10.el8.x86_64

How reproducible:

N/A

--- Additional comment from RHEL Program Management on 2021-07-12 06:58:20 UTC ---

The keyword FutureFeature has been added. If this bug is not a FutureFeature, please remove from the Summary field any strings containing "RFE, rfe, FutureFeature, FEAT, Feat, feat".

--- Additional comment from Pavel Najman on 2021-09-06 15:16:15 UTC ---

Setting the new sst value

--- Additional comment from Ben Marzinski on 2022-02-03 22:30:57 UTC ---

To test this you need to verify that

1. You can add options to the defaults section of multipath.conf by running

# mpathconf --option <option_name>:<option_value>

when the option doesn't exist in the defaults section. 

2. You can change the value of options that exist in the defaults section of multipath.conf by running the above command with a different <option_value> than the current value.

3. You can remove options from the defaults section of multipath.conf by running

# mpathconf --option <option_name>:

4. This feature is documented

Comment 3 Lin Li 2022-02-15 03:58:34 UTC

[root@storageqe-05 ~]# mpathconf --option option_name:3
[root@storageqe-05 ~]# cat /etc/multipath.conf
# device-mapper-multipath configuration file

# For a complete list of the default configuration values, run either:
# # multipath -t
# or
# # multipathd show config

# For a list of configuration options with descriptions, see the
# multipath.conf man page.

defaults {
	option_name 3  <---------------------------------------
	user_friendly_names yes
	find_multipaths yes
}

blacklist {
}
[root@storageqe-05 ~]# mpathconf --option option_name:5
[root@storageqe-05 ~]# cat /etc/multipath.conf
# device-mapper-multipath configuration file

# For a complete list of the default configuration values, run either:
# # multipath -t
# or
# # multipathd show config

# For a list of configuration options with descriptions, see the
# multipath.conf man page.

defaults {
	option_name 5 <---------------------------------------
	user_friendly_names yes
	find_multipaths yes
}

blacklist {
}
[root@storageqe-05 ~]# 
[root@storageqe-05 ~]# mpathconf --option option_name:
[root@storageqe-05 ~]# cat /etc/multipath.conf
# device-mapper-multipath configuration file

# For a complete list of the default configuration values, run either:
# # multipath -t
# or
# # multipathd show config

# For a list of configuration options with descriptions, see the
# multipath.conf man page.

defaults { <---------------------------------------
	user_friendly_names yes
	find_multipaths yes
}

blacklist {
}

Comment 4 Lin Li 2022-02-15 04:00:09 UTC

Verified on device-mapper-multipath-0.8.7-5.el9
[root@storageqe-05 ~]# rpm -qa | grep multipath
device-mapper-multipath-libs-0.8.7-5.el9.x86_64
device-mapper-multipath-0.8.7-5.el9.x86_64

Comment 6 errata-xmlrpc 2022-05-17 15:56:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: device-mapper-multipath), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3971