Bug 2051055
| Summary: | Review Request: kpublictransport - Library to assist with accessing public transport timetables and other data | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Justin Zobel <justin.zobel> |
| Component: | Package Review | Assignee: | Mark E. Fuller <mark.e.fuller> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mark.e.fuller, package-review, vitaly |
| Target Milestone: | --- | Flags: | mark.e.fuller:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-11 14:15:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Justin Zobel
2022-02-06 03:11:12 UTC
On initial review, there are two issues that get flagged: - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages Some additional things: -the devel package should have "Requires: %{name}%{?_isa} = %{version}-%{release}" -are tests being run? I see no %check section in the spec file, but a "tests" directory in the source code: please add this section and run tests if applicable Spec URL: https://pagure.io/kpublictransport_rpm/raw/master/f/kpublictransport.spec SRPM URL: https://pagure.io/kpublictransport_rpm/raw/master/f/kpublictransport-21.12.2-1.fc35.src.rpm Updated all requested items, updated version to latest as well. Looks like all the requested changes have been made and that the package is compliant - approved > %{_kf5_libdir}/*.so.* Please add soversion number here to avoid accidental bumps: %{_kf5_libdir}/*.so.0* > %{_kf5_libdir}/cmake/* Must be moved to -devel subpackage. > License: BSD and CC0-1.0 and LGPLv2+ and MIT and ODbL-1.0
Please remove a separate License field from the -devel subpackage.
Thanks for the additional review, Vitaly and catching the missed items - I will make a note of these items for my future reviews I will sponsor you to the packagers group. Have made the requested changes, URLs remain the same. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kpublictransport Thank you all for your help, repository created and builds happening. FEDORA-2022-7f42d9f3fc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7f42d9f3fc FEDORA-2022-89d565f1ef has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-89d565f1ef FEDORA-2022-28beac300c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-28beac300c FEDORA-2022-7f42d9f3fc has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-7f42d9f3fc` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7f42d9f3fc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-28beac300c has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-28beac300c` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-28beac300c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-89d565f1ef has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-89d565f1ef` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-89d565f1ef See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-7f42d9f3fc has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-28beac300c has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-89d565f1ef has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |