Bug 2051177

Summary: Review Request: rust-system-interface - Extensions to the Rust standard library
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Aleksei Bavshin <alebastr89>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: alebastr89, package-review
Target Milestone: ---Flags: alebastr89: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-10 22:35:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2051167    
Bug Blocks: 2051232    

Description Fabio Valentini 2022-02-06 15:03:41 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-system-interface.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-system-interface-0.17.1-1.fc35.src.rpm

Description:
Extensions to the Rust standard library.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2022-02-06 15:05:44 UTC
Note: It is not possible to package the latest version right now (0.20.0).
Version 0.17.1 is needed, because that matches the versions of dependencies in Fedora, and because that is what the latest wasmtime / cranelift packages depend on.

Comment 2 Fabio Valentini 2022-02-06 17:25:17 UTC
Successful COPR builds of all packages for all available architectures:
https://copr.fedorainfracloud.org/coprs/decathorpe/wasmtime/monitor/

Comment 3 Aleksei Bavshin 2022-03-09 15:42:39 UTC
I'm assuming that we're fine with disabled optional features as nothing else in Fedora uses these crates.
====
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fabio Valentini 2022-03-10 13:25:25 UTC
Yeah, if something will start to depend on any of the dropped optional features, I'll have to package the missing dependencies.

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/42885
https://pagure.io/releng/fedora-scm-requests/issue/42886
https://pagure.io/releng/fedora-scm-requests/issue/42887
https://pagure.io/releng/fedora-scm-requests/issue/42888

Comment 5 Gwyn Ciesla 2022-03-10 14:45:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-system-interface

Comment 6 Fabio Valentini 2022-03-10 22:35:37 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1932206

Will be submitted to bodhi and built for stable branches shortly.