Bug 2051406

Summary: Need commit hash in package json and logs
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: akmithal <akmithal>
Component: buildAssignee: Boris Ranto <branto>
Status: CLOSED ERRATA QA Contact: Daniel Horák <dahorak>
Severity: high Docs Contact:
Priority: high    
Version: 4.9CC: branto, etamir, lmauda, madam, muagarwa, ocs-bugs, odf-bz-bot, pbalogh
Target Milestone: ---   
Target Release: ODF 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ocs-registry:4.10.0-156 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-13 18:52:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description akmithal 2022-02-07 08:13:01 UTC
Description of problem (please be detailed as possible and provide log
snippests):

Need commit hash in package json and logs


Version of all relevant components (if applicable):


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?

Yes, this would help in debugging by development teams

Is there any workaround available to the best of your knowledge?
No

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?

Yes

Can this issue reproduce from the UI?


If this is a regression, please provide more details to justify this:


Steps to Reproduce:

Inside noobaa logs there should be a commit hash next in the package.json and in the logs.

from the upstream logs:
$ kubectl logs pod/noobaa-core-0 | grep "Version"
Version is: 5.10.0-82e1120

Feb-3 15:14:29.534 [BGWorkers/38]    [L0] core.server.bg_services.cluster_hb:: writing cluster server heartbeat to DB. heartbeat: { version: '5.10.0-82e1120', time: 1643901268536, health: { usage: 0.04878745969330378, os_info: {
      { _id: 61fbe1a7d9a8fa002ba4ae1f, heartbeat: { version: '5.10.0-82e1120', time: 1643901268536, health: { usage: 0.04878745969330378, os_info: [Object], storage: [Object] } }, services_status: { dns_status: 'OPERATIONAL', ph_status: { status: 'OPERATIONAL', test_time: 1643901269 } } }

$ kubectl exec -it pod/noobaa-core-0 -- cat /root/node_modules/noobaa-core/package.json | grep version
  "version": "5.10.0-82e1120",

and in the downstream the version is:
kubectl exec -it pod/noobaa-core-0 -- cat /root/node_modules/noobaa-core/package.json | grep version
  "version": "5.10.0

Actual results:
"version": "5.10.0

Expected results:
"version": "5.10.0-82e1120",

Additional info:

Comment 2 Nimrod Becker 2022-02-07 08:17:40 UTC
We need this in the build process

Comment 13 Daniel Horák 2022-02-24 13:25:32 UTC
Tested and verified on ocs-registry:4.10.0-167:

$ oc version
Client Version: 4.10.0-0.nightly-2022-02-23-193238
Server Version: 4.10.0-0.nightly-2022-02-23-193238
Kubernetes Version: v1.23.3+5642c2c


~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ oc logs pod/noobaa-core-0 | grep -i version
Version is: 5.10.0-7e1a1d4
...
      { _id: 62173b1cf11ea3002947488d, heartbeat: { version: '5.10.0-7e1a1d4', time: 1645689670536, health: { usage: 0.031364599740509314, os_info: [Object], storage: [Object] } }, services_status: { dns_status: 'OPERATIONAL', ph_status: { status: 'OPERATIONAL', test_time: 1645689670 } } }
...
      version: '5.10.0-7e1a1d4',
...
 oc exec -it pod/noobaa-core-0 -- cat /root/node_modules/noobaa-core/package.json | grep version
  "version": "5.10.0-7e1a1d4",
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Noobaa version in logs and package.json contains commit hash.

>> VERIFIED

Comment 15 errata-xmlrpc 2022-04-13 18:52:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.10.0 enhancement, security & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1372