Bug 2051854

Summary:	Review Request: oneVPL-intel-gpu - Intel oneVPL GPU Runtime
Product:	[Fedora] Fedora	Reporter:	Simone Caronni <negativo17>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	airlied, ngompa13, package-review, ppisar, rfontana
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	ngompa13: fedora-review+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-17 19:07:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Simone Caronni 2022-02-08 08:06:05 UTC

Spec URL: https://slaanesh.fedorapeople.org/oneVPL-intel-gpu.spec
SRPM URL: https://slaanesh.fedorapeople.org/oneVPL-intel-gpu-22.2.0-1.fc35.src.rpm
Description:
Intel® oneVPL GPU Runtime is a Runtime implementation of oneVPL API for Intel
Gen GPUs. Runtime provides access to hardware-accelerated video decode, encode
and filtering.

Fedora Account System Username: slaanesh

Comment 1 Neal Gompa 2022-02-08 13:19:27 UTC

Taking this review.

Comment 2 Neal Gompa 2022-02-08 13:22:07 UTC

> Intel® oneVPL GPU Runtime

We don't use (R)/(C)/(TM) or their unicode equivalents: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_summary_or_description

Please drop them on import.

Other than that...

Review notes:

* Packaging complies with the guidelines
* Package builds and installs
* No serious issues from rpmlint
* Licensing is correct and license files are correctly installed

PACKAGE APPROVED.

Comment 3 Simone Caronni 2022-02-09 08:41:39 UTC

(In reply to Neal Gompa from comment #2)
> > Intel® oneVPL GPU Runtime
> 
> We don't use (R)/(C)/(TM) or their unicode equivalents:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_trademarks_in_summary_or_description
> 
> Please drop them on import.

Ah! I missed that. I will do.

Thanks!

Comment 4 Gwyn Ciesla 2022-02-10 14:48:25 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/oneVPL-intel-gpu

Comment 5 Dave Airlie 2022-08-17 05:51:57 UTC

Did this have any legal review? there is definitely some possible patented stuff that could be linked to this.

Comment 6 Simone Caronni 2022-08-17 08:13:40 UTC

Nope, I was not aware sorry. How to trigger a legal review after the package is already available?

Comment 7 Dave Airlie 2022-09-22 00:44:03 UTC

I'm reopening this for legal review, based on it seems to enable APIs for h264/5 decoding from what I understand of the package.

Comment 8 Petr Pisar 2022-09-29 15:47:35 UTC

Reverting review state back to "fedora-review?".

Comment 9 Neal Gompa 2022-11-15 15:53:51 UTC

(In reply to Dave Airlie from comment #7)
> I'm reopening this for legal review, based on it seems to enable APIs for
> h264/5 decoding from what I understand of the package.

As far as I know this thing can't do anything without a functioning driver component, which is being reviewed in bug 1942132 with the encumbered codecs stripped.

Comment 10 Neal Gompa 2022-11-15 16:19:23 UTC

For some additional protection, we could also add "-DMFX_ENABLE_H264_VIDEO_DECODE=OFF -DMFX_ENABLE_H265_VIDEO_DECODE=OFF -DMFX_ENABLE_VC1_VIDEO_DECODE=OFF -DMFX_ENABLE_H264_VIDEO_ENCODE=OFF -DMFX_ENABLE_H265_VIDEO_ENCODE=OFF" to the cmake option list to forcibly disable those runtime paths entirely.

Comment 11 Richard Fontana 2022-11-17 17:13:54 UTC

Lifting FE-Legal.