Bug 2052055

Summary:	Whereabouts should implement client-go 1.22+
Product:	OpenShift Container Platform	Reporter:	Douglas Smith <dosmith>
Component:	Networking	Assignee:	Miguel Duarte Barroso <mduarted>
Networking sub component:	multus	QA Contact:	Weibin Liang <weliang>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	urgent
Priority:	urgent
Version:	4.11
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2052062 (view as bug list)		Environment:
Last Closed:	2022-08-10 10:47:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2052062

Description Douglas Smith 2022-02-08 15:36:56 UTC

Description of problem: Client-go 1.22+ includes fixes for retries against the API server. While client-go 1.23 is preferable, 1.22 has the fixes we're looking for.


Version-Release number of selected component (if applicable): (all)


How reproducible: The primary problems are reproducible in CI during upgrades, specifically when the SDN is upgrading, this appears in an unacceptable percentage of runs.

Steps to verify: Presence of client-go 1.22 in go.mod & no regressions.

Comment 4 Douglas Smith 2022-02-10 19:18:18 UTC

To verify, you can check if the shipped binary contains the version of the client-go library, for example:


```
$ oc debug node/ci-ln-1w66kgk-72292-smb8z-worker-a-tbxm5
Starting pod/ci-ln-1w66kgk-72292-smb8z-worker-a-tbxm5-debug ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.128.2
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host
sh-4.4# cat /var/lib/cni/bin/whereabouts | grep -i "0\.22\.6"
Binary file (standard input) matches
```

The command `cat /var/lib/cni/bin/whereabouts | grep -i "0\.22\.6"` should produce the output `Binary file (standard input) matches` -- if that is the case, it's verified. If it doesn't match it will have no output, and $? will produce `1` (or another non-zero value)

Comment 5 Weibin Liang 2022-02-10 19:31:06 UTC

Tested and verified in 4.11.0-0.nightly-2022-02-10-031822

[weliang@weliang ~]$ oc debug node/ip-10-0-139-148.us-east-2.compute.internal
Starting pod/ip-10-0-139-148us-east-2computeinternal-debug ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.139.148
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host
sh-4.4# 
sh-4.4# cat /var/lib/cni/bin/whereabouts | grep -i "0\.22\.6"
Binary file (standard input) matches
sh-4.4#

Comment 7 errata-xmlrpc 2022-08-10 10:47:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069