Bug 2052967

Summary:	Kitty overrides $PS1 for other terminal emulators
Product:	[Fedora] Fedora	Reporter:	Doncho Gunchev <dgunchev>
Component:	kitty	Assignee:	Artem <ego.cordatus>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	35	CC:	ego.cordatus, michel, zawertun
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	kitty-0.24.2-8.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-02-13 01:15:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Doncho Gunchev 2022-02-10 11:10:53 UTC

Description of problem:
/etc/profile.d/kitty.sh overrides PS1 for every single terminal emulator. The result is the cursor is changed globally. In my case from 'block' in konsole it turned to 'I beam'.

Version-Release number of selected component (if applicable):
kitty-0.24.2-6.fc35.x86_64


How reproducible:
Every time

Steps to Reproduce:
1. install kitty-0.24.2-6.fc35.x86_64
2. start konsole
3. type a command and watch the cursor shape change

Actual results:
Cursor shape changes, konsole is affected

Expected results:
integration does not affect other terminal emulators

Additional info:
A simple check like

if [ $(readlink -f "/proc/$PPID/exe") == "/usr/bin/kitty" ]; then

...

fi

in /etc/profile.d/kitty.sh fixes it for me.

Comment 1 Yaroslav Sidlovsky 2022-02-10 11:34:02 UTC

Thanks for the report!

Comment 2 Fedora Update System 2022-02-11 09:54:43 UTC

FEDORA-2022-ee8f86925f has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ee8f86925f

Comment 3 Doncho Gunchev 2022-02-11 11:39:11 UTC

Just updated, "${KITTY_PID}" is nice, 10x.

Comment 4 Yaroslav Sidlovsky 2022-02-11 13:06:22 UTC

Good to know, thanks for testing!

Comment 5 Fedora Update System 2022-02-12 01:39:30 UTC

FEDORA-2022-ee8f86925f has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-ee8f86925f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-ee8f86925f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2022-02-13 01:15:43 UTC

FEDORA-2022-ee8f86925f has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.