Bug 2053505

Summary: [LSO]Error message about "ErrorFindingMatchingDisk" is not clear for cr localvolume when no volume attached to worker
Product: OpenShift Container Platform Reporter: Chao Yang <chaoyang>
Component: StorageAssignee: Fabio Bertinatto <fbertina>
Storage sub component: Local Storage Operator QA Contact: Chao Yang <chaoyang>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: medium CC: jsafrane
Version: 4.11   
Target Milestone: ---   
Target Release: 4.13.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-17 01:39:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chao Yang 2022-02-11 12:53:20 UTC
Description of problem:
Error message about "ErrorFindingMatchingDisk" is not clear for cr localvolume when no volume attached to worker. 

Version-Release number of selected component (if applicable):
local-storage-operator.4.10.0-202202101606

How reproducible:
Always

Steps to Reproduce:
1.Deploy Local Storage Operator
2.Did not attach volume to chaoyang-ibm028-25qbc-worker-3-fb9xm
3.oc describe localvolume/example
Name:         example
Namespace:    openshift-local-storage
Labels:       <none>
Annotations:  <none>
API Version:  local.storage.openshift.io/v1
Kind:         LocalVolume
Metadata:
  Creation Timestamp:  2022-02-11T06:00:44Z
  Finalizers:
    storage.openshift.com/local-volume-protection
  Generation:  2
  Managed Fields:
    API Version:  local.storage.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        .:
        f:storageClassDevices:
    Manager:      Mozilla
    Operation:    Update
    Time:         2022-02-11T06:00:44Z
    API Version:  local.storage.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:finalizers:
          .:
          v:"storage.openshift.com/local-volume-protection":
      f:spec:
        f:logLevel:
        f:managementState:
    Manager:      local-storage-operator
    Operation:    Update
    Time:         2022-02-11T06:00:44Z
    API Version:  local.storage.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:conditions:
        f:generations:
        f:managementState:
        f:observedGeneration:
        f:readyReplicas:
    Manager:         local-storage-operator
    Operation:       Update
    Subresource:     status
    Time:            2022-02-11T06:00:44Z
  Resource Version:  1540618
  UID:               8ac0670e-c992-45eb-929d-12141b7f43d6
Spec:
  Log Level:         Normal
  Management State:  Managed
  Storage Class Devices:
    Device Paths:
      /dev/vdd
    Fs Type:             ext4
    Storage Class Name:  foobar
    Volume Mode:         Filesystem
Status:
  Conditions:
    Last Transition Time:  2022-02-11T06:00:44Z
    Message:               Ready
    Status:                True
    Type:                  Available
  Generations:
    Group:              apps
    Last Generation:    3
    Name:               diskmaker-manager
    Namespace:          openshift-local-storage
    Resource:           DaemonSet
  Management State:     Managed
  Observed Generation:  2
  Ready Replicas:       0
Events:
  Type     Reason                    Age   From                            Message
  ----     ------                    ----  ----                            -------
  Warning  ErrorFindingMatchingDisk  25m   localvolume-symlink-controller  chaoyang-ibm028-25qbc-worker-3-fb9xm -  was defined in devicePaths, but expected a path in /dev/
  Warning  DeviceSymlinkExists       59s   localvolume-symlink-controller  chaoyang-ibm028-25qbc-worker-2-vf7wj - not symlinking, already claimed: [/mnt/local-storage/foobar1/virtio-0797-173db308-7554-4]
  Normal   FoundMatchingDisk         58s   localvolume-symlink-controller  chaoyang-ibm028-25qbc-worker-1-jxm4q - found matching disk /dev/vdd with id /dev/disk/by-id/virtio-0787-1a9ddbfe-9912-4
  Warning  ErrorFindingMatchingDisk  54s   localvolume-symlink-controller  chaoyang-ibm028-25qbc-worker-3-fb9xm -  was defined in devicePaths, but expected a path in /dev/

Actual results:
"  Warning  ErrorFindingMatchingDisk  25m   localvolume-symlink-controller  chaoyang-ibm028-25qbc-worker-3-fb9xm -  was defined in devicePaths, but expected a path in /dev/"

https://github.com/openshift/local-storage-operator/blob/843d3cadfcae3f68ef267387a2deffbc57a217b3/diskmaker/controllers/lv/reconcile.go#L419


Expected results:

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

Comment 3 Chao Yang 2022-12-07 09:18:16 UTC
al - found empty matching device list
  Warning  ErrorFindingMatchingDisk  34s   localvolume-symlink-controller  ip-10-0-201-120.us-east-2.compute.internal - unable to add disk /dev/vdd to local disk pool: lstat /dev/vdd: no such file or directory
  Warning  ErrorFindingMatchingDisk  34s   localvolume-symlink-controller  ip-10-0-201-120.us-east-2.compute.internal - found empty matching device list

local-storage-operator.v4.13.0-202212060045

Comment 6 errata-xmlrpc 2023-05-17 01:39:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.13.0 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:1327