Bug 2053604

Summary:	pcp-testsuite installs executables under /var/lib/
Product:	[Fedora] Fedora	Reporter:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Component:	pcp	Assignee:	Nathan Scott <nathans>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	agerstmayr, jkurik, mgoodwin, nathans, ngompa13
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-02-14 10:12:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2051550, 2053607

Description Zbigniew Jędrzejewski-Szmek 2022-02-11 15:34:21 UTC

Description of problem:
pcp does $subject, which is against the FHS and the more modern file-hierarchy(7) standard. It is surprising, and will cause problems when e.g. changes like https://fedoraproject.org/wiki/Changes/VarSubvol4SilverblueKinoite are implemented. Distro executables need to live under /usr/.

Version-Release number of selected component (if applicable):
pcp-testsuite-5.3.6-2.fc36.x86_64

How reproducible:
Deterministic

Steps to Reproduce:
1. file /var/lib/pcp/testsuite/*/* | grep ELF

Actual results:
/var/tmp/f36/var/lib/pcp/testsuite/perfevent/perfevent_coverage
/var/tmp/f36/var/lib/pcp/testsuite/perfevent/perfevent_test
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/bigun/bigun.so
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/broken/broken_pmda_2_0
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/broken/broken_pmda_2_1
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/broken/broken_pmda_2_2
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/broken/broken_pmda_2_3
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/broken/broken_pmda_2_4
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/broken/broken_pmda_2_5
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/dynamic/pmdadynamic
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/github-56/pmdatrivial
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/schizo/pmdaschizo-A
/var/tmp/f36/var/lib/pcp/testsuite/pmdas/schizo/pmdaschizo-B
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_context/qmc_context
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_desc/qmc_desc
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_dynamic/qmc_dynamic
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_event/qmc_event
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_format/qmc_format
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_group/qmc_group
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_hosts/qmc_hosts
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_indom/qmc_indom
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_metric/qmc_metric
/var/tmp/f36/var/lib/pcp/testsuite/qt/qmc_source/qmc_source
/var/tmp/f36/var/lib/pcp/testsuite/src/libnvidia-ml.so

Expected results:
(nothing)

Comment 1 Nathan Scott 2022-02-13 22:24:44 UTC

This affects the pcp-testsuite package only - this is a package for QE purposes not end users, so I'm inclined to close this as WONTFIX.

Are there any situations where the testsuite would not function with its executables (and everything else) under /var?  It'd be a major headache to change, for no practical purpose AFAICS.  Thanks for any insights.

Comment 2 Zbigniew Jędrzejewski-Szmek 2022-02-14 09:30:55 UTC

If those files are not really used for anything, then probably this won't have much effect.

Comment 3 Zbigniew Jędrzejewski-Szmek 2022-02-14 10:01:14 UTC

But, man, this is just so ugly. Why not fix it?

Comment 4 Nathan Scott 2022-02-14 10:12:41 UTC

| If those files are not really used for anything

The files are used for testing, nothing more (nothing less).

| then probably this won't have much effect.

Agreed.

| Why not fix it?

Because there's only 24 hours in a day and useful work trumps wasted efforts like changing pcp-testsuite paths would be.

Thanks for your insights!

cheers.