Bug 2053872

Summary:	Changing Upstream URL of a custom repo in WebUI raises error "Upstream password requires upstream username be set."
Product:	Red Hat Satellite	Reporter:	Pavel Moravec <pmoravec>
Component:	Repositories	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	Cole Higgins <chiggins>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.11.0	CC:	pcreech, sajha
Target Milestone:	6.11.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	tfm-rubygem-katello-4.3.0.35-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-05 14:33:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Moravec 2022-02-12 20:52:17 UTC

Description of problem:
Attempting to update Upstream URL of a custom repo via WebUI fails with error:

An error occurred saving the Repository: Validation failed: Upstream password requires upstream username be set.

Doing the same via hammer, no validation fails.

Also when one updates any other setting of the repo (e.g. just edit "Verify SSL" and save without a change), then updating the URL do pass.


Version-Release number of selected component (if applicable):
Sat 7.0 snap 9


How reproducible:
100%


Steps to Reproduce:
1. Create a custom product and a custom repo with whatever Upstream URL.
2. In WebUI, edit the Upstream URL and click to Save.
3. Edit Verify SSL, optionally (un)check the option or leave unchanged, and save.
4. Edit the Upstream URL again.
5. Do the same change via hammer.


Actual results:
2. fails with the above Validation failed error
4. succeeds
5. succeeds


Expected results:
2. to succeed as well


Additional info:

Comment 3 Pavel Moravec 2022-04-04 14:14:58 UTC

After "oh, I cant reproduce either", I realized this is tricky :)

My observation: whenever I am creating a new yum repo in WebUI, I get upstream username and password pre-filled. To admin / (admin's WebUI password). That is filled by my *Firefox* that stores credentials to the Satellite WebUI and recognizes the fields as login username/password fields.

So, when I allow Firefox to store my WebUI credentials, it pre-fills them to any new repo being created. The original bug report is a result of such confusion (I guess I removed the username but not password and tried to save it).


So the real bugreport should be "change some meta-information about the input fields for upstream username and upstream password, such that FF does not pre-fill with auto-saved credentials". Which makes the bug of less priority but still valid, I guess.

Comment 5 Bryan Kearney 2022-05-11 00:04:30 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/34818 has been resolved.

Comment 12 errata-xmlrpc 2022-07-05 14:33:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5498