Bug 2054160
Summary: | FRR reloader does not disable BFD when unsetting BFD profile | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 8 | Reporter: | Carlos Goncalves <cgoncalves> |
Component: | frr | Assignee: | Michal Ruprich <mruprich> |
Status: | CLOSED ERRATA | QA Contact: | FrantiĊĦek Hrdina <fhrdina> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 8.4 | CC: | fhrdina, jorton, mruprich |
Target Milestone: | rc | Keywords: | AutoVerified, Reproducer, Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | frr-7.5.1-3.el8 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-11-08 09:39:31 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 2050824 |
Description
Carlos Goncalves
2022-02-14 10:26:57 UTC
Proposed fix upstream: https://github.com/FRRouting/frr/pull/10570 Any updates on this FRR issue? Just a reminder that this impacts an OpenShift component. The workaround imposes temporary network dataplane disruption. Hi Carlos, sorry I had to move to other stuff before actually coming up with the solution here. I was thinking of using the PR that you issued for upstream as a solution in RHEL8 and wait for anything the upstream comes up with but here it seems they don't have this on their radar at this point. I think that for RHEL8 we could use the solution that you provided but it needs a little tweak in the code as well. The frr-reload.py script is a bit simple in a way that it takes differences in the config and applies them to the running config. Your suggestion works great with the latest version but version of FRR in RHEL8 has a problem when printing the bfd information. It leaves out the part with 'neighbor PEER bfd': if (!CHECK_FLAG(bfd_info->flags, BFD_FLAG_PARAM_CFG) && (bfd_info->type == BFD_TYPE_NOT_CONFIGURED)) { vty_out(vty, " neighbor %s bfd", addr); <<----here it should be separated by \n if (bfd_info->profile[0]) vty_out(vty, " profile %s", bfd_info->profile); <<---- neighbor <peer> bfd should be here. vty_out(vty, "\n"); } I am fixing this part with my patch, it has worked for me so far. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (frr bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:7560 |