Bug 2054234

Summary: ldns fails to build with Python 3.11: error: unknown type name 'Py_buffer'
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: ldnsAssignee: Paul Wouters <paul.wouters>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mhroncok, paul.wouters, pemensik, rlescak, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-09 09:36:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2016048    

Description Tomáš Hrnčiar 2022-02-14 13:44:43 UTC
ldns fails to build with Python 3.11.0a4.

In file included from /usr/include/python3.11/object.h:733,
                 from /usr/include/python3.11/Python.h:42,
                 from ./contrib/python/ldns_wrapper.c:154:
/usr/include/python3.11/cpython/object.h:50:42: error: unknown type name 'Py_buffer'; did you mean 'ldns_buffer'?
   50 | typedef int (*getbufferproc)(PyObject *, Py_buffer *, int);
      |                                          ^~~~~~~~~
      |                                          ldns_buffer
/usr/include/python3.11/cpython/object.h:51:47: error: unknown type name 'Py_buffer'; did you mean 'ldns_buffer'?
   51 | typedef void (*releasebufferproc)(PyObject *, Py_buffer *);
      |                                               ^~~~~~~~~
      |                                               ldns_buffer
/usr/include/python3.11/cpython/object.h:134:6: error: unknown type name 'getbufferproc'
  134 |      getbufferproc bf_getbuffer;
      |      ^~~~~~~~~~~~~
/usr/include/python3.11/cpython/object.h:135:6: error: unknown type name 'releasebufferproc'
  135 |      releasebufferproc bf_releasebuffer;
      |      ^~~~~~~~~~~~~~~~~

Py_buffer and APIs are now part of the limited API and the stable ABI:
    PyObject_CheckBuffer()
    PyObject_GetBuffer()
    PyBuffer_GetPointer()
    PyBuffer_SizeFromFormat()
    PyBuffer_ToContiguous()
    PyBuffer_FromContiguous()
    PyBuffer_CopyData()
    PyBuffer_IsContiguous()
    PyBuffer_FillContiguousStrides()
    PyBuffer_FillInfo()
    PyBuffer_Release()
    PyMemoryView_FromBuffer()
    bf_getbuffer and bf_releasebuffer type slots

(Contributed by Christian Heimes in bpo-45459.)


https://docs.python.org/3.11/whatsnew/3.11.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/03442692-ldns/

For all our attempts to build ldns with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/ldns/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Richard Lescak 2022-03-09 09:02:15 UTC
Hi,

this looks like a Python problem.

Final changes related to this issue [1] were made few days ago, and are included in latest release 3.11.0a6.

This last version have pybuffer.h with definition of Py_buffer, what wasn't the case in previous ones.


[1] https://bugs.python.org/issue45459

Comment 2 Tomáš Hrnčiar 2022-03-09 09:36:52 UTC
Hello,

yes, it was indeed fixed with 3.11.0a6. I am closing this issue.

https://copr.fedorainfracloud.org/coprs/g/python/python3.11/build/3639263/