Bug 2054782
Summary: | DataImportCron status does not show failure when failing to create dataSource | ||
---|---|---|---|
Product: | Container Native Virtualization (CNV) | Reporter: | Ruth Netser <rnetser> |
Component: | Storage | Assignee: | Arnon Gilboa <agilboa> |
Status: | CLOSED ERRATA | QA Contact: | Yan Du <yadu> |
Severity: | low | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.10.0 | CC: | cnv-qe-bugs, mrashish, yadu |
Target Milestone: | --- | ||
Target Release: | 4.10.1 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | CNV v4.10.1-75 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-05-18 20:27:03 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 2083039, 2091982 |
Description
Ruth Netser
2022-02-15 17:03:21 UTC
There are two aspects for this: 1. we should report dataimportcron conditions of this kind 2. we should use a hashing when naming the datasource, similar to the datavolume controller creates the PVC (In reply to Yan Du from comment #1) > There are two aspects for this: > 1. we should report dataimportcron conditions of this kind > 2. we should use a hashing when naming the datasource, similar to the > datavolume controller creates the PVC This cannot be done; common templates refer to given dataSource names. This is why dataSources were introduced - a resource with a static name which dynamically points to a PVC (which can be replaced) The names and labels length issue is already covered by bz 2046686 fix for 4.10.1: https://github.com/kubevirt/containerized-data-importer/pull/2220/commits/715fed8bb82974472603a839abd0cb37008d4512#diff-786a9fcaa47bbf5a42fae757e2e41d06f646e2e8b778e9c17a6ab595ef9a52fbL824-R890 Test on CNV-v4.10.1-62, got below error after set custom dataimportcron: {"level":"error","ts":1649760447.0815444,"logger":"controller.dataimportcron-controller","msg":"Reconciler error","name":"","namespace":"openshift-virtualization-os-images","error":"values[0][cdi.kubevirt.io/dataImportCron]: Invalid value: \"openshift-virtualization-os-images.\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')","errorCauses":[{"error":"values[0][cdi.kubevirt.io/dataImportCron]: Invalid value: \"openshift-virtualization-os-images.\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')"}],"stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"} Updated fixed in version to a bundle including PR 2239 Test on CNV v4.10.1-78, issue has been fixed. Need to retest on the build contains PR 2249 Verified on CNV-v4.10.1-101 We can see some recurring Reconciler error in cdi deployment pod after adding custom dataimportcron to hco till the import finished. Talked with Arnon, since it doesn't affect the import function, let's track the issue in #2083039 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Virtualization 4.10.1 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:4668 |