Bug 2054863

Summary: Consistency in naming mediatedDevicesTypes and nodemediatedDeviceTypes
Product: Container Native Virtualization (CNV) Reporter: Kedar Bidarkar <kbidarka>
Component: InstallationAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED ERRATA QA Contact: Akriti Gupta <akrgupta>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.10.0CC: acardace, dbasunag, dholler, fdeutsch, pousley, sgott, stirabos, zpeng
Target Milestone: ---   
Target Release: 4.14.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hco-bundle-registry-container-v4.14.0.rhel9-1102 Doc Type: Bug Fix
Doc Text:
Cause: mediatedDevicesTypes and nodeMediatedDeviceTypes were not consistently named Consequence: this could lead to confusion Fix: mediatedDevicesTypes became mediatedDeviceTypes Result: mediatedDeviceTypes and nodeMediatedDeviceTypes are consistent
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-16 14:09:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kedar Bidarkar 2022-02-15 20:41:53 UTC
Description of problem:

Consistency in naming mediatedDevicesTypes and nodemediatedDeviceTypes is needed

Version-Release number of selected component (if applicable):
4.10

How reproducible:
Always

Steps to Reproduce:
1. update the HCO CR with mediatedDevices Configuration 

  mediatedDevicesConfiguration:
    mediatedDevicesTypes:
    - nvidia-231
    nodeMediatedDeviceTypes:
    - mediatedDevicesTypes:
      - nvidia-233
      nodeSelector:
        kubernetes.io/hostname: node-11.redhat.com
  permittedHostDevices:
    mediatedDevices:
    - mdevNameSelector: GRID T4-2Q
      resourceName: nvidia.com/GRID_T4-2Q
    - mdevNameSelector: GRID T4-8Q
      resourceName: nvidia.com/GRID_T4-8Q
2.
3.

Actual results:
 mediatedDevicesTypes  and nodeMediatedDeviceTypes 

Notice, "Devices" plural and "Device" Singular.

Expected results:
Feel, it should be consistent.

Additional info:

Comment 1 sgott 2022-02-16 13:23:35 UTC
deferring to the next release as there is no danger of data loss.

Comment 2 Antonio Cardace 2022-11-18 15:58:31 UTC
Deferring to 4.13 as it's past blockers-only and it's not considered a 4.12 blocker.

Comment 9 Antonio Cardace 2023-06-20 12:30:43 UTC
@stirabos can you check if this bug is actually an HCO one as pointed out by Jed?

Comment 10 Akriti Gupta 2023-07-21 08:08:18 UTC
Verified on v4.14.0.rhel9-1259
[akriti@fedora ~]$ oc edit hco kubevirt-hyperconverged -n openshift-cnv -o yaml
[akriti@fedora ~]$ oc get hco kubevirt-hyperconverged -n openshift-cnv -o yaml | grep -A 8 mediatedDevicesConfiguration:
  mediatedDevicesConfiguration:
    mediatedDeviceTypes:
    - nvidia-231
    nodeMediatedDeviceTypes:
    - mediatedDeviceTypes:
      - nvidia-233
      nodeSelector:
        kubernetes.io/hostname: node-11.redhat.com
  resourceRequirements:


mediatedDeviceTypes did not disappear and mediatedDeviceTypes under nodeMediatedDeviceTypes can be saved under HCO

Comment 19 errata-xmlrpc 2023-08-16 14:09:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.13.3 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:4664