Bug 2055049

Summary:	No pre-caching for NFD images
Product:	OpenShift Container Platform	Reporter:	Artyom <alukiano>
Component:	Node Feature Discovery Operator	Assignee:	Carlos Eduardo Arango Gutierrez <carangog>
Status:	CLOSED ERRATA	QA Contact:	Lena Horsley <lhorsley>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	4.11	CC:	aos-bugs, sejug
Target Milestone:	---
Target Release:	4.11.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2055244 (view as bug list)		Environment:
Last Closed:	2022-08-10 10:23:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2052622, 2055244

Description Artyom 2022-02-16 09:26:47 UTC

Description of problem:

In Telco far edge use case, a cluster might have limited management bandwidth.
Upgrading such a cluster is expected to be time-limited (capped by a maintenance window) and will involve container image pre-caching on the node.
Image pre-caching solution for nodes with limited management bandwidth relies on the assumption, that workloads can use locally stored images without contacting a registry.  This is possible if the container image pull policy is set to "IfNotPresent".
The NFD operator is using Always as the pull policy, we should delete the policy and have the default behavior:

When you (or a controller) submit a new Pod to the API server, your cluster sets the image pull policy field when specific conditions are met:

1. if you omit the imagePullPolicy field, and the tag for the container image is :latest, imagePullPolicy is automatically set to Always

2. if you omit the imagePullPolicy field, and you don't specify the tag for the container image, imagePullPolicy is automatically set to Always;

3.if you omit the imagePullPolicy field, and you specify the tag for the container image that isn't :latest, the imagePullPolicy is automatically set to IfNotPresent.


Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Artyom 2022-02-16 09:55:22 UTC

After digging into the documentation, I can see it is possible to specify the image pull policy during the creation of NFD components.

From https://docs.openshift.com/container-platform/4.9/hardware_enablement/psap-node-feature-discovery-operator.html:

You can edit the CR to choose another namespace, image, imagePullPolicy, and nfd-worker-conf, among other options.

But we still should update the operator pull policy to correct one.

Comment 7 errata-xmlrpc 2022-08-10 10:23:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.11.0 extras and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5070