Bug 2055244

+++ This bug was initially created as a clone of Bug #2055049 +++

Description of problem:

In Telco far edge use case, a cluster might have limited management bandwidth.
Upgrading such a cluster is expected to be time-limited (capped by a maintenance window) and will involve container image pre-caching on the node.
Image pre-caching solution for nodes with limited management bandwidth relies on the assumption, that workloads can use locally stored images without contacting a registry.  This is possible if the container image pull policy is set to "IfNotPresent".
The NFD operator is using Always as the pull policy, we should delete the policy and have the default behavior:

When you (or a controller) submit a new Pod to the API server, your cluster sets the image pull policy field when specific conditions are met:

1. if you omit the imagePullPolicy field, and the tag for the container image is :latest, imagePullPolicy is automatically set to Always

2. if you omit the imagePullPolicy field, and you don't specify the tag for the container image, imagePullPolicy is automatically set to Always;

3.if you omit the imagePullPolicy field, and you specify the tag for the container image that isn't :latest, the imagePullPolicy is automatically set to IfNotPresent.


Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Artyom on 2022-02-16 09:55:22 UTC ---

After digging into the documentation, I can see it is possible to specify the image pull policy during the creation of NFD components.

From https://docs.openshift.com/container-platform/4.9/hardware_enablement/psap-node-feature-discovery-operator.html:

You can edit the CR to choose another namespace, image, imagePullPolicy, and nfd-worker-conf, among other options.

But we still should update the operator pull policy to correct one.