Bug 2055358

Summary: Summary Interval Hardcoded in PTP Operator if Set in the Global Body Instead of Command Line
Product: OpenShift Container Platform Reporter: OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component: NetworkingAssignee: Joseph Richard <josricha>
Networking sub component: ptp QA Contact: obochan <obochan>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: augol, keyoung
Version: 4.10   
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-10 16:44:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2051593    
Bug Blocks: 2057072    

Description OpenShift BugZilla Robot 2022-02-16 18:35:31 UTC 
+++ This bug was initially created as a clone of Bug #2051593 +++

Created attachment 1859597 [details]
a yaml to reproduce the problem

Description of problem:
When summary interval is not set on the command line, the PTP operator adds "--summary_interval=1" to the command line over-riding the settings in

Version-Release number of selected component (if applicable):
4.10 - needs to be backported 

How reproducible:
100%

Steps to Reproduce:
1.  remove any summary interval specification in the ptp4l command line
2.  Set summary interval in the global section of the ptp configuration yaml (i.e., -4)
3.

Actual results:
The running ptp4l daemon will have summary interval = 1

Expected results:
The running ptp4l daemon will have summary interval = -4

Additional info:
Comment 2 obochan 2022-03-01 18:57:38 UTC 
The issue is verified via version
[obochan@obochan ptp_goLang]$ oc version 
Client Version: 4.8.0
Server Version: 4.10.0-rc.6
Kubernetes Version: v1.23.3+e419edf

[obochan@obochan ptp_goLang]$ oc describe ptpconfigs.ptp.openshift.io -n openshift-ptp worker | grep summ
summary_interval -2
    ptp4lOpts:                -2 -s --summary_interval -4


you can see at the logs the command take priority which means 16 msg per 1, i did verfiction also by removing adding back and changing the value all look ok.

ptp4l[7074.985]: [ptp4l.0.config] master offset          2 s2 freq   -1035 path delay       365
ptp4l[7075.049]: [ptp4l.0.config] master offset          2 s2 freq   -1035 path delay       365
ptp4l[7075.105]: [ptp4l.0.config] master offset          2 s2 freq   -1035 path delay       364
ptp4l[7075.169]: [ptp4l.0.config] master offset         -3 s2 freq   -1043 path delay       364
ptp4l[7075.233]: [ptp4l.0.config] master offset          6 s2 freq   -1028 path delay       364
ptp4l[7075.297]: [ptp4l.0.config] master offset          0 s2 freq   -1038 path delay       364
ptp4l[7075.361]: [ptp4l.0.config] master offset         -1 s2 freq   -1040 path delay       363
ptp4l[7075.417]: [ptp4l.0.config] master offset         -2 s2 freq   -1041 path delay       363
ptp4l[7075.481]: [ptp4l.0.config] master offset          4 s2 freq   -1031 path delay       363
ptp4l[7075.545]: [ptp4l.0.config] master offset          6 s2 freq   -1028 path delay       363
ptp4l[7075.609]: [ptp4l.0.config] master offset          0 s2 freq   -1037 path delay       363
ptp4l[7075.673]: [ptp4l.0.config] master offset          5 s2 freq   -1029 path delay       363
ptp4l[7075.729]: [ptp4l.0.config] master offset         -2 s2 freq   -1040 path delay       363
ptp4l[7075.793]: [ptp4l.0.config] master offset          4 s2 freq   -1030 path delay       363
ptp4l[7075.857]: [ptp4l.0.config] master offset          5 s2 freq   -1028 path delay       363
ptp4l[7075.921]: [ptp4l.0.config] master offset          3 s2 freq   -1031 path delay       363
ptp4l[7075.985]: [ptp4l.0.config] master offset         -4 s2 freq   -1043 path delay       364
ptp4l[7076.049]: [ptp4l.0.config] master offset         -2 s2 freq   -1040 path delay       364
ptp4l[7076.105]: [ptp4l.0.config] master offset          6 s2 freq   -1026 path delay       364
ptp4l[7076.169]: [ptp4l.0.config] master offset          1 s2 freq   -1034 path delay       364
ptp4l[7076.233]: [ptp4l.0.config] master offset          1 s2 freq   -1034 path delay       364
ptp4l[7076.297]: [ptp4l.0.config] master offset         -6 s2 freq   -1046 path delay       364
ptp4l[7076.361]: [ptp4l.0.config] master offset         -3 s2 freq   -1041 path delay       364
ptp4l[7076.417]: [ptp4l.0.config] master offset         -1 s2 freq   -1038 path delay       364
ptp4l[7076.481]: [ptp4l.0.config] master offset         -3 s2 freq   -1042 path delay       363
ptp4l[7076.545]: [ptp4l.0.config] master offset         -2 s2 freq   -1040 path delay       363
ptp4l[7076.609]: [ptp4l.0.config] master offset          5 s2 freq   -1028 path delay       363
ptp4l[7076.673]: [ptp4l.0.config] master offset          1 s2 freq   -1035 path delay       362
ptp4l[7076.738]: [ptp4l.0.config] master offset         -3 s2 freq   -1042 path delay       362
ptp4l[7076.793]: [ptp4l.0.config] master offset          3 s2 freq   -1032 path delay       362
ptp4l[7076.857]: [ptp4l.0.config] master offset          6 s2 freq   -1026 path delay       362
ptp4l[7076.921]: [ptp4l.0.config] master offset          2 s2 freq   -1032 path delay       362
ptp4l[7076.985]: [ptp4l.0.config] master offset         -3 s2 freq   -1041 path delay       363
Comment 4 errata-xmlrpc 2022-03-10 16:44:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056