Bug 2055883

Summary:	Specifies non-symbolic icon names that have been retired by adwaita-icon-theme
Product:	[Fedora] Fedora	Reporter:	Adam Williamson <awilliam>
Component:	anaconda	Assignee:	Radek Vykydal <rvykydal>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	36	CC:	anaconda-maint-list, jkonecny, jonathan, kellin, mkolman, rvykydal, vanmeeuwen+fedora, vponcova, w
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	anaconda-36.16.4-1.fc36	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-05 00:16:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Williamson 2022-02-17 20:46:13 UTC

I noticed that adwaita-icon-theme 42 retires a lot of the "legacy" full color (not 'symbolic') icons it used to carry. See https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/blob/42.beta/NEWS#L5 .

This caused anaconda to crash on startup, but on further investigation that bug was in blivet-gui.

anaconda does specify icon names that have been retired in several places, but the way anaconda handles things, it doesn't result in a crash like it does in blivet-gui. It looks like GTK+ actually winds up giving anaconda the equivalent symbolic icons - e.g. we ask for "dialog-error" and GTK+ gives us "dialog-error-symbolic". At least, I couldn't catch anywhere it crashed or showed no icon or an error icon.

Given this, I'm not sure if we want to patch everywhere to use the symbolic icon names explicitly, or just keep relying on GTK+ to find them for us? So instead of sending a PR I figured I'd start with a bug report. I do have a branch where I updated all of the retired non-symbolic names I could find, can send a PR from it if desired.

Comment 1 Vendula Poncova 2022-02-22 14:29:13 UTC

Hi Adam! Feel free to open a pull request.

Comment 2 Adam Williamson 2022-02-25 16:26:04 UTC

https://github.com/rhinstaller/anaconda/pull/3902

Comment 3 Adam Williamson 2022-02-25 16:26:40 UTC

Well, I'm still not sure if changing this is actually the best thing to do, but there you go :) May be worth checking with GNOME folks whether it's considered better or worse to specify the -symbolic.

Comment 4 Jiri Konecny 2022-02-28 14:05:03 UTC

We need to fix one more icon which is present only on the F36: https://github.com/rhinstaller/anaconda/pull/3905

Comment 5 Martin Kolman 2022-02-28 14:16:34 UTC

As we are under beta freeze, I think this will need to have a FE/blocker granted to get in.

Comment 6 Jiri Konecny 2022-03-01 10:04:05 UTC

AFAIK there is automatic fallback to these icons now so it's not blocking anything. Which means that we can wait after the freeze to get this in. Also we need to fix the big icons. These looks really bad right now.

Comment 7 Adam Williamson 2022-03-01 17:34:31 UTC

Yeah, I don't think we need to rush this into Beta. Can just do it after Beta is done.

Comment 8 Radek Vykydal 2022-03-17 08:53:21 UTC

(In reply to Jiri Konecny from comment #6)
> AFAIK there is automatic fallback to these icons now so it's not blocking
> anything. Which means that we can wait after the freeze to get this in. Also
> we need to fix the big icons. These looks really bad right now.

https://github.com/rhinstaller/anaconda/pull/3962

Comment 9 Fedora Update System 2022-03-30 13:05:11 UTC

FEDORA-2022-8538fa94da has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8538fa94da

Comment 10 Fedora Update System 2022-03-31 18:24:55 UTC

FEDORA-2022-8538fa94da has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-8538fa94da`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8538fa94da

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-04-01 23:23:06 UTC

FEDORA-2022-8538fa94da has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-8538fa94da`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8538fa94da

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-04-05 00:16:26 UTC

FEDORA-2022-8538fa94da has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.