Bug 2056245

Summary:	Review Request: maui-mauikit-texteditor - MauiKit Text Editor components
Product:	[Fedora] Fedora	Reporter:	Onuralp SEZER <thunderbirdtr>
Component:	Package Review	Assignee:	Jakub Kadlčík <jkadlcik>
Status:	CLOSED DEFERRED	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jkadlcik, package-review, tdawson
Target Milestone:	---	Flags:	jkadlcik: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-09-20 15:33:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Onuralp SEZER 2022-02-20 12:48:38 UTC

Spec URL: https://pagure.io/Maukit-Packages/raw/main/f/mauikit-texteditor/mauikit-texteditor.spec
SRPM URL: https://pagure.io/Maukit-Packages/raw/main/f/mauikit-texteditor/maui-mauikit-texteditor-2.1.1-1.fc37.src.rpm
Description: MauiKit Text Editor components
Fedora Account System Username: thunderbirdtr

Comment 1 Jakub Kadlčík 2022-11-22 20:13:58 UTC

Hello Onuralp,
thank you for the package.


> Issues:
> =======
> - Spec file name must match the spec package %{name}, in the format
>   %{name}.spec.
>   Note: mauikit-texteditor.spec should be maui-mauikit-texteditor.spec
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_spec_file_naming

Can you please fix the spec name / package name?


> Version:        2.1.1

There is already 2.2.0, can you please update?


> %description
> %{summary}.

There is some usable text in the project README. Could be better but
it's better than using %{summary}

> MauiKitTextEditor is a set of QtQuick components providing basic
> text editing capabilities. 


> %files

Can you add `%doc README.md` as well?

Comment 2 Package Review 2023-11-23 00:45:25 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 3 Jakub Kadlčík 2023-11-23 15:22:25 UTC

I am interested in reviewing this ticket but there is no response from the contributor.

Comment 4 Troy Dawson 2024-09-20 15:33:52 UTC

I am going to close this review request.
It has been a few years, the code has changed, and there is a different packager that would like to package this.

Thank you Onuralp for your initial work on this package.
Thank you Jakub for your initial review.