Bug 2057558

Summary:	Marketplace operator polls too frequently for cluster operator status changes
Product:	OpenShift Container Platform	Reporter:	Anik <anbhatta>
Component:	OLM	Assignee:	Per da Silva <pegoncal>
OLM sub component:	OLM	QA Contact:	Jian Zhang <jiazha>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	krizza, pegoncal, pupadhya, tyslaton
Version:	4.10
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: Info level logs were being generated during operator-marketplace polling Consequence: log spam Fix: reduced the log line to debug level and added more control over log levels for the user via command line flag Result: reduced log spam	Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-10 10:50:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Anik 2022-02-23 15:33:20 UTC

Description of problem:

The marketplace operator polls the cluster operator to change it's status every 20s. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:

High polling interval leads to log/api server spamming. 

Expected results:

1. Increase the polling interval 
2. Consider changing the log level to Debug instead of Info. 

Additional info:

https://github.com/operator-framework/operator-marketplace/blob/master/pkg/status/status.go#L26

Comment 1 Jian Zhang 2022-03-03 09:00:58 UTC

1, Create a cluster with the fixed PR via cluster-bot
mac:~ jianzhang$ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.10.0-0.ci.test-2022-03-03-081213-ci-ln-t4bvn5b-latest   True        False         100s    Cluster version is 4.10.0-0.ci.test-2022-03-03-081213-ci-ln-t4bvn5b-latest

2, Check the marketplace operator logs.
mac:~ jianzhang$ oc project openshift-marketplace
Now using project "openshift-marketplace" on server "https://api.ci-ln-t4bvn5b-76ef8.origin-ci-int-aws.dev.rhcloud.com:6443".
mac:~ jianzhang$ oc get pods
NAME                                    READY   STATUS    RESTARTS      AGE
certified-operators-fpdn5               1/1     Running   0             26m
community-operators-ht48k               1/1     Running   0             26m
marketplace-operator-7d76d4ff95-8frk5   1/1     Running   1 (19m ago)   29m
redhat-marketplace-rp6qn                1/1     Running   0             26m
redhat-operators-pfcnd                  1/1     Running   0             26m
mac:~ jianzhang$ oc logs marketplace-operator-7d76d4ff95-8frk5
time="2022-03-03T08:35:57Z" level=info msg="Go Version: go1.17.5"
time="2022-03-03T08:35:57Z" level=info msg="Go OS/Arch: linux/amd64"
time="2022-03-03T08:35:57Z" level=info msg="[metrics] Registering marketplace metrics"
...
...
time="2022-03-03T08:52:33Z" level=info msg="[status] Previous and current ClusterOperator Status are the same, the ClusterOperator Status will not be updated."
time="2022-03-03T08:53:33Z" level=info msg="[status] Previous and current ClusterOperator Status are the same, the ClusterOperator Status will not be updated."
time="2022-03-03T08:54:33Z" level=info msg="[status] Previous and current ClusterOperator Status are the same, the ClusterOperator Status will not be updated."

The status upgrading interval has been changed to 60s. LGTM, verify it.

Comment 6 errata-xmlrpc 2022-08-10 10:50:55 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069