Bug 2058661
| Summary: | Since FF94 if a CA has no subject we get "improperly formatted DER-encoded message" | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michele Baldessari <michele> |
| Component: | nss | Assignee: | Bob Relyea <rrelyea> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 35 | CC: | crypto-team, elio.maldonado.batiz, erack, gecko-bugs-nobody, jeckersb, jfischer, jgato, jhorak, kai-engert-fedora, kdudka, klaas, pe.antonov, pjasicek, rhughes, rrelyea, rstrode, sandmann, stransky, tbielawa, zeguan |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-09 09:19:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michele Baldessari
2022-02-25 14:45:06 UTC
Bob, any idea here? Moving to NSS to get attention of NSS crew, please move back if that's a Firefox bug. Thanks. In NSS there are multiple cert validators: 1) the classic validator, 2) libpkix, 3) Firefox pkix. certutil uses the classic validator, and can be told to use libpkix. Firefox uses the firefox pkix validator, which has not been integrated into NSS proper. It lives in the NSS tree, but doesn't have it's own shared library. As part of the NSS release, we don't build it, but it would land into mozilla with a new release of NSS. I think a good test is: run the fedora Firefox 93 with NSS 3.72 installed. If the problems are still there, then it's likely some change in NSS that only the Firefox validator sees. If goes away, then it's probably in the Firefox validator (which would be in the firefox package in our release). bob Please try the experiment outlined in comment 3. Thanks. Oh, wait, the issue was introduced in 3.71, so the patch I put up was irrelevant. The test is still valid, though. If you can run Firefox 93 with NSS 3.72 without a problem, then we know it's in mozpkix. The root cause for this is most likely, that GitOps Operator creates an own CA certificate to sign other TLS certificates it creates. However, it doesn't set a Subject for the CA certificate. This is most likely what Firefox doesn't like about the certificate presented by GitOps Operator. Once the CA certificate has a subject set, Firefox happily accepts the TLS certificate of GitOps Operator. Tested with Firefox 97.0.1 (64-bit) Upstream PR https://github.com/argoproj-labs/argocd-operator/pull/582 Thanks everyone. I changed the subject to something more searchable in case someone else hits this. While it'd be nice if the error from firefox were a bit more informative, this change in behavior w/ FF94 is not really a bug, so I'll close this one out. Thanks again! Hi,
I am having the same issue with Fedora 35 and Firefox 100. What is the solution? By the moment I patching ArgoCD with:
oc patch argocd -n openshift-gitops openshift-gitops --type='merge' -p '{"spec":{"server":{"route":{"tls":{"termination":"reencrypt"}}}}}'
@jgato The CA creation has been fixed in OpenShift GitOps 1.5.0. For new installs and instances, it should work ootb now. If you upgraded, you need to * first delete the openshift-gitops-ca secret and let the Operator recreate it to establish a new CA, * then delete the openshift-gitops-tls secret and let the Operator recreate it to create a new cert, signed by the new CA. HTH. do you know if this will be also solved on previous versions like 1.4.x? No, sorry, we haven't backported this fix. I think the suggestion would be to either use reencrypt (as you already do), or to provide your own CA keypair in openshift-gitops-tls. If you choose the latter, openshift-gitops-tls secret has to be deleted/re-created as well. |