Bug 2058961

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=83408642

I'll take care of it.

I've noticed there are some bad things generated by pyp2rpm.

Some are harmless:

You don't need this:

 # Remove bundled egg-info
 rm -rf %{pypi_name}.egg-info

This has been deprecated:

  %{?python_provide:%python_provide python3-%{pypi_name}}


But others are quite serious:

  Requires:       python3dist(coverage)
  Requires:       python3dist(pytest)
  Requires:       python3dist(pytest-randomly)
  Requires:       python3dist(pytest-xdist)

Why would you require pytets and coverage on runtime?


Please, don't blindly submit spec files generated by pyp2rpm.

I've reported https://github.com/fedora-python/pyp2rpm/issues/283

Upstream description has more details about what Unicodedata is since they have a link to it. that would be nice to have small description of it in %description maybe. otherwise it is quite difficult to see what this package is for.

Thank you Akira for picking this for review. I have updated this package and links are below.

Thank you Miro for your comment. Yes I blindly trusted on pyp2rpm and when submitted this package, I submitted it in a hurry and did not look back. Sorry. I have corrected now the SPEC file.

Please suggest any further improvements to this packaging.

SPEC URL: https://pnemade.fedorapeople.org/fedora-work/python-unicodedata2.spec
SRPM URL: https://pnemade.fedorapeople.org/fedora-work/python-unicodedata2-14.0.0-2.fc36.src.rpm

I'd do the following changes.

@@ -13,7 +13,6 @@
 
 BuildRequires:  gcc
 BuildRequires:  python3-devel
-BuildRequires:  python3dist(coverage)
 BuildRequires:  python3dist(pytest)
 BuildRequires:  python3dist(pytest-randomly)
 BuildRequires:  python3dist(pytest-xdist)
@@ -50,7 +49,7 @@
 %py3_install
 
 %check
-PYTHONPATH=%{buildroot}%{python3_sitearch} %{__python3} -m pytest -v
+%pytest -v
 
 %files -n python3-%{pypi_name}
 %license LICENSE


1) coverage appears unused and is discouraged in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters
2) %pytest somehow looks easier and does not add $PWD to sys.path

Updated based on above suggestions.

SPEC URL: https://pnemade.fedorapeople.org/fedora-work/python-unicodedata2.spec
SRPM URL: https://pnemade.fedorapeople.org/fedora-work/python-unicodedata2-14.0.0-3.fc36.src.rpm

One suggestion:
--- srpm/python-unicodedata2.spec       2022-05-17 12:04:36.580973618 +0900
+++ srpm-unpacked/python-unicodedata2.spec      2022-05-17 14:49:39.732691109 +0900
@@ -54,7 +54,7 @@
 %files -n python3-%{pypi_name}
 %license LICENSE
 %doc README.md
-%{python3_sitearch}/%{pypi_name}.cpython-*
+%{python3_sitearch}/%{pypi_name}%{python3_ext_suffix}
 %{python3_sitearch}/%{pypi_name}-%{pypi_version}-py%{python3_version}.egg-info
 
 %changelog

Otherwise looks good to me.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0". 20
     files have unknown license. Detailed output of licensecheck in
     /var/home/tagoh/2058961-python-unicodedata2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-unicodedata2
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
python3-unicodedata2: /usr/lib64/python3.10/site-packages/unicodedata2.cpython-310-x86_64-linux-gnu.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/u/unicodedata2/unicodedata2-14.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 41f7df0043f4450e84203d907a56cdd2a0a0541a9eebbaba48576b01e0b61684
  CHECKSUM(SHA256) upstream package : 41f7df0043f4450e84203d907a56cdd2a0a0541a9eebbaba48576b01e0b61684


Requires
--------
python3-unicodedata2 (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    python(abi)
    rtld(GNU_HASH)

python-unicodedata2-debugsource (rpmlib, GLIBC filtered):



Provides
--------
python3-unicodedata2:
    python-unicodedata2
    python3-unicodedata2
    python3-unicodedata2(x86-64)
    python3.10-unicodedata2
    python3.10dist(unicodedata2)
    python3dist(unicodedata2)

python-unicodedata2-debugsource:
    python-unicodedata2-debugsource
    python-unicodedata2-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2058961
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, C/C++, Shell-api
Disabled plugins: Java, fonts, Perl, Ocaml, Haskell, SugarActivity, PHP, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Thank you Akira.
As its just one line minor change, I kept same n-v-r and updated package is below.

SPEC URL: https://pnemade.fedorapeople.org/fedora-work/python-unicodedata2.spec
SRPM URL: https://pnemade.fedorapeople.org/fedora-work/python-unicodedata2-14.0.0-3.fc36.src.rpm

Sorry, I wasn't aware of the updates. that looks good to me. APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-unicodedata2

Built and available in F36+