Bug 2059566

Summary: Bootdisks are still left behind in /tmp when Satellite is restarted
Product: Red Hat Satellite Reporter: Lukas Zapletal <lzap>
Component: Bootdisk PluginAssignee: Lukas Zapletal <lzap>
Status: CLOSED DUPLICATE QA Contact: Roman Plevka <rplevka>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.10.0CC: ahumbe, gpadholi, lzap, onerleka
Target Milestone: 6.11.0Keywords: EasyFix, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-03 09:41:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lukas Zapletal 2022-03-01 10:51:33 UTC
Bootdisk generation cannot cleanup files properly after they are downloaded due to use of send_file Ruby on Rails technique. Therefore we implemented auto-cleanup which cleans all bootdisk temporary directories older than 30 minutes as part of:

https://bugzilla.redhat.com/show_bug.cgi?id=1936946

However, since /tmp is managed by systemd and Foreman process runs with private tmp, this will not work after Satellite is restarted. Therefore the final solution must be implemented:

1) Change the temporary (bootdisk work directory) from /tmp to /var/tmp/bootdisk (*)
2) Ensure the directory exists in the code, if not, create it
3) Ensure the directory is created by RPM/DEB packages with correct ownership
4) Verify SELinux policy (it should be allowed but check this)

(*) https://github.com/theforeman/foreman_bootdisk/blob/master/app/services/foreman_bootdisk/iso_generator.rb#L89

Comment 4 Lukas Zapletal 2022-05-03 09:41:50 UTC

*** This bug has been marked as a duplicate of bug 2081280 ***