Bug 2059593

Summary:	[ibm] Offline resizing volume is kept running for ibm vpc csi driver.
Product:	OpenShift Container Platform	Reporter:	Chao Yang <chaoyang>
Component:	Storage	Assignee:	OpenShift Storage Bugzilla Bot <ocp-storage-bot>
Storage sub component:	Storage	QA Contact:	Chao Yang <chaoyang>
Status:	CLOSED WONTFIX	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	aos-bugs, hekumar, jsafrane
Version:	4.11
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-10 16:39:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2042348

Description Chao Yang 2022-03-01 12:35:57 UTC

Description of problem:
Offline resizing volume is kept running for ibm vpc csi driver.

Version-Release number of selected component (if applicable):
4.11.0-0.nightly-2022-02-27-122819

How reproducible:
Always

Steps to Reproduce:
1.Install OCP on ibm cloud
2.Create pvc/pod
3.Delete pod
4.Resize pvc volume to 11Gi
5.oc describe pvc
  Warning  ExternalExpanding      67m                volume_expand                                                                                            Ignoring the PVC: didn't find a plugin capable of expanding the volume; waiting for an external controller to process this PVC.
  Normal   Resizing               67m                external-resizer vpc.block.csi.ibm.io                                                                    External resizer is resizing volume pvc-e39afb9a-a365-4807-ab0d-5aaa8c29e2ab
  Normal   Resizing               54m                external-resizer vpc.block.csi.ibm.io                                                                    External resizer is resizing volume pvc-e39afb9a-a365-4807-ab0d-5aaa8c29e2ab
  Normal   Resizing               42m                external-resizer vpc.block.csi.ibm.io                                                                    External resizer is resizing volume pvc-e39afb9a-a365-4807-ab0d-5aaa8c29e2ab
  Normal   Resizing               29m                external-resizer vpc.block.csi.ibm.io                                                                    External resizer is resizing volume pvc-e39afb9a-a365-4807-ab0d-5aaa8c29e2ab
  Normal   Resizing               16m                external-resizer vpc.block.csi.ibm.io                                                                    External resizer is resizing volume pvc-e39afb9a-a365-4807-ab0d-5aaa8c29e2ab
  Normal   Resizing               3m49s              external-resizer vpc.block.csi.ibm.io                                                                    External resizer is resizing volume pvc-e39afb9a-a365-4807-ab0d-5aaa8c29e2ab


Actual results:


Expected results:
Expect offline resizing is end within some time and give the message that not supported offline expansion.

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

Comment 2 Jan Safranek 2022-03-04 09:21:24 UTC

This looks like a CSI driver problem.

Comment 3 Arashad Ahamad 2022-03-07 10:01:23 UTC

Jan Safranek, 

Offline volume expansion not supported in the vpc csi block driver.

Comment 4 Arashad Ahamad 2022-03-07 13:46:57 UTC

raised PR for the same https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/pull/70

Comment 5 Hemant Kumar 2022-03-07 16:41:31 UTC

So that change alone will not fix anything. We were in-fact planning to deprecate the online and offline capabilities - https://github.com/container-storage-interface/spec/pull/429 

So what we are asking is, if a volume plugin only supports online expansion then external-resizer should not make `ControllerExpandVolume` call if volume is offline. I am afraid this will require a change in external-resizer.

Comment 6 Arashad Ahamad 2022-03-10 11:27:50 UTC

I was trying to test my changes and its not working as expected hence I discuss with CSI community and come to know that its not supported hence I opened a defect against external-resizer https://github.com/kubernetes-csi/external-resizer/issues/197

Discussion can be found here https://kubernetes.slack.com/archives/C8EJ01Z46/p1646750799978489

So my PR is not valid till be get confirmation from community,  defect fix is on hold