Bug 2059734
| Summary: | Support for 16KB pages ? | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] LVM and device-mapper | Reporter: | jmranger | ||||
| Component: | lvm2 | Assignee: | LVM and device-mapper development team <lvm-team> | ||||
| lvm2 sub component: | Default / Unclassified | QA Contact: | cluster-qe <cluster-qe> | ||||
| Status: | CLOSED NEXTRELEASE | Docs Contact: | |||||
| Severity: | unspecified | ||||||
| Priority: | unspecified | CC: | agk, heinzm, jbrassow, marcan, msnitzer, prajnoha, teigland, thornber, zkabelac | ||||
| Version: | unspecified | Flags: | pm-rhel:
lvm-technical-solution?
pm-rhel: lvm-test-coverage? |
||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-04-07 19:28:06 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
jmranger
2022-03-01 20:55:34 UTC
Just to be clear: 16K *is* a completely standard ARM64 page size (albeit one supported by relatively few SoCs). So it is a bug for LVM2 to treat it as a nonstandard/unexepected page size. Hi, I'd like to include that patch, do you know how we could test it before applying it? Apologies for the delay. $life kind of got in the way. I still have a setup to test this, although I don't use it that much in that configuration. So it depends on the kind of validation you're hoping for. Sanity check? Sure. Thorough burn-in? Probably not. Machine on which you can get a remote access? Sorry - I'm not in a position to offer that, although if that's what you need, it's not necessarily impossible to organize. What did you have in mind? Obviously, there's nothing I (or the Asahi community as a whole) can test until there's a proposed patch ;-) Thanks and Regards, jmranger A sanity check would be fine: pvcreate /dev/foo vgcreate test /dev/foo lvcreate -l1 -n lv1 test pvs /dev/foo lvs test/lv1 pvck --dump headers /dev/foo pvck --dump metadata /dev/foo vgchange -an test vgremove -y test It would be nice to see the output from that sequence of commands. I've added the patch from comment 1 to this devel branch for you to build and test: https://sourceware.org/git/?p=lvm2.git;a=shortlog;h=refs/heads/dev-dct-16KB-page-size Created attachment 1956259 [details] result to the test asked in comment #5 (Not sure why I didn't - and still don't - see the patch as an attachment. Sorry for this.) Here's the output you requested. Please note that I did it twice, first with the parent commit, then with the patch applied. Please also note that the configured step ended with the following warning, which I ignored: configure: WARNING: Unrecognized 'vdoformat' tool is REQUIRED for VDO logical volume creation! Please let me know if there's anyting else I can do. Regards, jmranger Thanks, it works. The patch (with one small addition) in the main branch: https://sourceware.org/git/?p=lvm2.git;a=commit;h=b443eac6efd29a72a4356f54c713cc9a0e0da866 I must admit that I fail to understand how both extra changes are related to the 16K support, but if the exercise helped find and fix other issues at the same time, I'm all for it. Thanks for your help! Thanks for pointing that out, there was an unrelated config.c change that snuck into that commit and I've removed that with another commit. The addition of: int mda_num = (mda_offset <= 65536) ? 1 : 2; fixes the output to display "mda_header_1" instead of "mda_header_2" for non-4k page sizes. Both make sense now. Thanks again. |