Bug 2059966

Summary: python-pytest-toolbox fails to build with pytest 7
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-pytest-toolboxAssignee: Fabian Affolter <mail>
Status: MODIFIED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 37CC: mail
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-11 22:05:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2045102, 2117176, 2168842, 2231791, 2050629    

Description Miro Hrončok 2022-03-02 12:16:27 UTC
In this copr repo, I have updated pytest to 7.0.1:

https://copr.fedorainfracloud.org/coprs/churchyard/pytest-7/

Based on this PR:

https://src.fedoraproject.org/rpms/pytest/pull-request/25

I'd like to update pytest to 7 in Fedora 37, but python-pytest-toolbox 0.4-10 fails to build.

https://copr.fedorainfracloud.org/coprs/churchyard/pytest-7/package/python-pytest-toolbox/

________________________ ERROR collecting test session _________________________
/usr/lib/python3.10/site-packages/pluggy/_hooks.py:265: in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
/usr/lib/python3.10/site-packages/pluggy/_manager.py:80: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
/usr/lib/python3.10/site-packages/pytest_isort.py:52: in pytest_collect_file
    return IsortItem.from_parent(parent, fspath=path)
/usr/lib/python3.10/site-packages/_pytest/nodes.py:633: in from_parent
    return super().from_parent(parent=parent, fspath=fspath, path=path, **kw)
/usr/lib/python3.10/site-packages/_pytest/nodes.py:264: in from_parent
    return cls._create(parent=parent, **kw)
/usr/lib/python3.10/site-packages/_pytest/nodes.py:140: in _create
    return super().__call__(*k, **kw)
/usr/lib/python3.10/site-packages/pytest_isort.py:160: in __init__
    super(IsortItem, self).__init__(name=path, parent=parent, **kwargs)
/usr/lib/python3.10/site-packages/_pytest/nodes.py:686: in __init__
    self._check_item_and_collector_diamond_inheritance()
/usr/lib/python3.10/site-packages/_pytest/nodes.py:708: in _check_item_and_collector_diamond_inheritance
    warnings.warn(
E   pytest.PytestWarning: IsortItem is an Item subclass and should not be a collector, however its bases File are collectors.
E   Please split the Collectors and the Item into separate node types.
E   Pytest Doc example: https://docs.pytest.org/en/latest/example/nonpython.html
E   example pull request on a plugin: https://github.com/asmeurer/pytest-flakes/pull/40/



There are several packages affected by this update, so I'd very much appreciate it if you could fix this failure. Please, check if your upstream hasn't already fixed it and backport the fix if possible. Report this failure to your upstream otherwise. If you need specific help, let me know.

Thanks!

Comment 1 Ben Cotton 2022-08-09 13:13:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 2 Fabian Affolter 2023-02-11 22:05:17 UTC
Upstream is no longer maintaining this module. Now retired.

Comment 3 Miro Hrončok 2023-02-11 22:24:31 UTC
Could you please also retire it in f38? Just merging this https://src.fedoraproject.org/rpms/python-pytest-toolbox/pull-request/2 should do it.