Bug 2059969

Summary:	python-ratelimiter fails to build with pytest 7
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-ratelimiter	Assignee:	Aniket Pradhan <aniketpradhan1999>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	aniketpradhan1999, code, neuro-sig
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-ratelimiter-1.2.0-7.post0.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-17 10:46:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2045102, 2050629

Description Miro Hrončok 2022-03-02 12:22:04 UTC

In this copr repo, I have updated pytest to 7.0.1:

https://copr.fedorainfracloud.org/coprs/churchyard/pytest-7/

Based on this PR:

https://src.fedoraproject.org/rpms/pytest/pull-request/25

I'd like to update pytest to 7 in Fedora 37, but python-ratelimiter 1.2.0-6.post0 fails to build.

https://copr.fedorainfracloud.org/coprs/churchyard/pytest-7/package/python-ratelimiter/

+ pytest-3.10
ImportError while loading conftest '/builddir/build/BUILD/ratelimiter-1.2.0.post0/tests/conftest.py'.
tests/conftest.py:9: in <module>
    class DummyCollector(pytest.collect.File):
/usr/lib/python3.10/site-packages/pytest/collect.py:34: in __getattr__
    warnings.warn(PYTEST_COLLECT_MODULE.format(name=name), stacklevel=2)
E   pytest.PytestRemovedIn7Warning: pytest.collect.File was moved to pytest.File
E   Please update to the new name.


There are several packages affected by this update, so I'd very much appreciate it if you could fix this failure. Please, check if your upstream hasn't already fixed it and backport the fix if possible. Report this failure to your upstream otherwise. If you need specific help, let me know.

Thanks!

Comment 1 Miro Hrončok 2022-03-02 12:22:13 UTC

Not that upstream pytest says: probably not worth trying to fix, it's related to code for Python < 3.5 and no upstream commits in over 4 years despite open issues/PRs

Comment 2 Ben Beasley 2022-03-16 16:18:47 UTC

As noted, upstream is defunct, but as long as ratelimiter is a snakemake dependency I think we’ll need to keep it around. So far the accumulating issues have been easy enough to fix

----

Fixed by upstream PR:
https://github.com/RazerM/ratelimiter/pull/13

…and corresponding downstream PR:
https://src.fedoraproject.org/rpms/python-ratelimiter/pull-request/2

It’s a trivial PR, but I’ll let @aniketpradhan1999 take a look at it rather than merging right away.

Comment 3 Fedora Update System 2022-03-17 10:45:06 UTC

FEDORA-2022-eb8155d972 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-eb8155d972

Comment 4 Fedora Update System 2022-03-17 10:46:57 UTC

FEDORA-2022-eb8155d972 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.